[Fusionforge-commits] r8284 - in trunk/gforge/www: . survey/admin tracker tracker/admin

Alain Peyrat aljeux at libremir.placard.fr.eu.org
Thu Oct 15 22:05:22 CEST 2009


Author: aljeux
Date: 2009-10-15 22:05:21 +0200 (Thu, 15 Oct 2009)
New Revision: 8284

Modified:
   trunk/gforge/www/sendmessage.php
   trunk/gforge/www/survey/admin/add_question.php
   trunk/gforge/www/survey/admin/edit_question.php
   trunk/gforge/www/survey/admin/edit_survey.php
   trunk/gforge/www/survey/admin/index.php
   trunk/gforge/www/survey/admin/show_results_aggregate.php
   trunk/gforge/www/tracker/admin/form-addcanned.php
   trunk/gforge/www/tracker/admin/form-addextrafield.php
   trunk/gforge/www/tracker/admin/form-addextrafieldoption.php
   trunk/gforge/www/tracker/admin/form-clonetracker.php
   trunk/gforge/www/tracker/admin/form-deleteextrafield.php
   trunk/gforge/www/tracker/admin/form-updatecanned.php
   trunk/gforge/www/tracker/taskmgr.php
Log:
xhtml fixes

Modified: trunk/gforge/www/sendmessage.php
===================================================================
--- trunk/gforge/www/sendmessage.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/sendmessage.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -119,15 +119,14 @@
 
 ?>
 
-<p>
+<p />
 <?php echo _('In an attempt to reduce spam, we are using this form to send email.<p />Fill it out accurately and completely or the receiver may not be able to respond.<p /><span class="important"><b>IF YOU ARE WRITING FOR HELP:</b> Did you read the site documentation? Did you include your <b>user_id</b> and <b>user_name?</b> If you are writing about a project, include your <b>project id</b> (<b>group_id</b>) and <b>Project Name</b>.</span>'); ?>
-</p>
-
+<p />
 <form action="<?php echo getStringFromServer('PHP_SELF'); ?>" method="post">
 <input type="hidden" name="form_key" value="<?php echo form_generate_key(); ?>" />
 <input type="hidden" name="toaddress" value="<?php echo $toaddress; ?>" />
 <input type="hidden" name="touser" value="<?php echo $touser; ?>" />
-<p />
+
 <strong><?php echo _('Your Name').utils_requiredField() ?> :</strong><br />
 <input type="text" name="name" size="40" maxlength="40" value="<?php echo $name ?>" />
 <p />

Modified: trunk/gforge/www/survey/admin/add_question.php
===================================================================
--- trunk/gforge/www/survey/admin/add_question.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/survey/admin/add_question.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -82,13 +82,12 @@
 ?>
 </p>
 
-<p><input type="submit" name="submit" value="<?php echo _('Add This Question.'); ?>"></p>
-</form></p>
+<p><input type="submit" name="submit" value="<?php echo _('Add This Question.'); ?>" /></p>
+</form>
 
-<p>
 <form>
 <input type="button" name="none" value="<?php echo _('Show Existing Questions.'); ?>" onclick="show_questions()" />
-</form></p>
+</form>
 
 <?php
 

Modified: trunk/gforge/www/survey/admin/edit_question.php
===================================================================
--- trunk/gforge/www/survey/admin/edit_question.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/survey/admin/edit_question.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -107,13 +107,12 @@
 ?>
 </p>
 
-<p><input type="submit" name="submit" value="<?php echo _('Submit Changes'); ?>"></p>
-</form></p>
+<p><input type="submit" name="submit" value="<?php echo _('Submit Changes'); ?>" /></p>
+</form>
 
-<p>
 <form>
 <input type="button" name="none" value="<?php echo _('Show Existing Questions'); ?>" onclick="show_questions()" />
-</form></p>
+</form>
 
 <?php
 

Modified: trunk/gforge/www/survey/admin/edit_survey.php
===================================================================
--- trunk/gforge/www/survey/admin/edit_survey.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/survey/admin/edit_survey.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -106,7 +106,6 @@
 <span class="warning"><?php echo _('WARNING! It is a bad idea to edit a survey after responses have been posted'); ?></span>
 
 <p><?php echo _('If you change a survey after you already have responses, your results pages could be misleading or messed up'); ?>.</p>
-<p>
 <form action="<?php echo getStringFromServer('PHP_SELF'); ?>" method="post">
 <input type="hidden" name="group_id" value="<?php echo $group_id; ?>" />
 <input type="hidden" name="post_changes" value="y" />
@@ -125,7 +124,7 @@
 <br /><input type="radio" name="is_active" value="0"<?php if ($is_active=='0') { echo ' checked="checked"'; } ?> /> <?php echo _('No'); ?></p>
 <p>
 <input type="submit" name="submit" value="<?php echo _('Submit Changes'); ?>"></p>
-</form></p>
+</form>
 
 <?php
 
@@ -138,10 +137,10 @@
 $numrows=db_numrows($result);
 
 ?>
-<p>
+
 <form>
 <input type="button" name="none" value="<?php echo _('Show Existing Questions'); ?>" onclick="show_questions()" />
-</form></p>
+</form>
 <p>&nbsp;</p>
 <h2><?php echo ngettext('Existing Survey', 'Existing Surveys', $numrows) ?></h2>
 <?php

Modified: trunk/gforge/www/survey/admin/index.php
===================================================================
--- trunk/gforge/www/survey/admin/index.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/survey/admin/index.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -46,16 +46,11 @@
 <p><?php printf(_('You can now activate/deactivate surveys on the %1$s Edit Existing Surveys %2$s page'), '<a href="'.util_make_url ('/survey/admin/survey.php?group_id='.$group_id).'">', '</a>'); ?>
 
 </p>
-<p>
+
 <?php
 
 $sh->footer(array());
 
-?>
-</p>
-
-<?php
-
 // Local Variables:
 // mode: php
 // c-file-style: "bsd"

Modified: trunk/gforge/www/survey/admin/show_results_aggregate.php
===================================================================
--- trunk/gforge/www/survey/admin/show_results_aggregate.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/survey/admin/show_results_aggregate.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -50,7 +50,7 @@
 echo "<h2>".db_result($result, 0, "survey_title")."</h2><p>&nbsp;</p>";
 
 /*
-echo "<h3><a href=\"show_results_csv.php?survey_id=$survey_id&group_id=$group_id\">.CSV File</a></h3><p>";
+echo "<h3><a href=\"show_results_csv.php?survey_id=$survey_id&amp;group_id=$group_id\">.CSV File</a></h3><p>";
 */
 
 /*

Modified: trunk/gforge/www/tracker/admin/form-addcanned.php
===================================================================
--- trunk/gforge/www/tracker/admin/form-addcanned.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/admin/form-addcanned.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -40,8 +40,7 @@
 		}
 		?>
 		<p><?php echo _('Creating useful generic messages can save you a lot of time when handling common artifact requests.') ?></p>
-		<p>
-		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<input type="hidden" name="add_canned" value="y" />
 		<strong><?php echo _('Title') ?>:</strong><br />
 		<input type="text" name="title" value="" size="50" maxlength="50" />

Modified: trunk/gforge/www/tracker/admin/form-addextrafield.php
===================================================================
--- trunk/gforge/www/tracker/admin/form-addextrafield.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/admin/form-addextrafield.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -83,13 +83,16 @@
 		echo "<h2>"._('Add New Custom Field')."</h2>";
 		?>
 		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
+		<p>
 		<input type="hidden" name="add_extrafield" value="y" />
-		<p>
 		<strong><?php echo _('Custom Field Name') ?>:</strong><br />
-		<input type="text" name="name" value="" size="15" maxlength="30" /><br />
+		<input type="text" name="name" value="" size="15" maxlength="30" />
+		</p>
 		<p>
 		<strong><?php echo _('Field alias') ?>:</strong><br />
-		<input type="text" name="alias" value="" size="15" maxlength="30" /><br />
+		<input type="text" name="alias" value="" size="15" maxlength="30" />
+		</p>
+
 		<p>
 		<strong><?php  echo _('Type of custom field') ?>:</strong><br />
 		<input type="radio" name="field_type" value="1" /> <?php echo _('Select Box'); ?><br />
@@ -106,9 +109,10 @@
 		<p>
 		<?php echo _('Text Fields and Text Areas need to have Size/Maxlength and Rows/Cols defined, respectively.'); ?><br />
 		<?php echo _('Text Field Size/Text Area Rows'); ?>
-			<input type="text" name="attribute1" value="0" size="2" maxlength="2"><br />
+			<input type="text" name="attribute1" value="20" size="2" maxlength="2" /><br />
 		<?php echo _('Text Field Maxlength/Text Area Columns'); ?>
-			<input type="text" name="attribute2" value="0" size="2" maxlength="2">
+			<input type="text" name="attribute2" value="80" size="2" maxlength="2" />
+		</p>
 		<p>
 		<span class="warning"><?php echo _('Warning: this add new custom field') ?></span>
 		</p>

Modified: trunk/gforge/www/tracker/admin/form-addextrafieldoption.php
===================================================================
--- trunk/gforge/www/tracker/admin/form-addextrafieldoption.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/admin/form-addextrafieldoption.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -58,6 +58,7 @@
 			</td>
 			<td align="left">
 			<input type="submit" name="post_changes_alphaorder" value="<?php echo _('Alphabetical order') ?>" />
+			<br />&nbsp;
 			</td>
 			</tr>
 			<?php echo $GLOBALS['HTML']->listTableBottom(); ?>
@@ -70,19 +71,18 @@
 		?>
 		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;boxid='.$boxid.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<input type="hidden" name="add_opt" value="y" />
-		<br />
-		<p>
+		<br /><br />
 		<strong><?php echo _('Add New Element') ?>:</strong>
 		<input type="text" name="name" value="" size="15" maxlength="30" />
 		<!--
 		Show a pop-up box to choose the possible statuses that this element will map to
 		-->
 		<?php if ($ac->getType() == ARTIFACT_EXTRAFIELDTYPE_STATUS) { ?>
-		<strong><?php echo _('Status'); ?></strong><br />
+		<strong>&nbsp;&nbsp;<?php echo _('Status'); ?></strong>
 		<?php echo $ath->statusBox('status_id',1,false,false); ?>
 		<?php } ?>
 		&nbsp;&nbsp;<input type="submit" name="post_changes" value="<?php echo _('Submit') ?>" />
-		</p>
+		<br />
 		<span class="warning"><?php echo _('Once you add a new element, it cannot be deleted') ?></span>
 		</form>
 		<br />

Modified: trunk/gforge/www/tracker/admin/form-clonetracker.php
===================================================================
--- trunk/gforge/www/tracker/admin/form-clonetracker.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/admin/form-clonetracker.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -30,7 +30,7 @@
 
 				?>
 				<p><?php echo _('Choose the template tracker to clone. The site administrator will have to set up trackers with default values and set permissions properly so you can access them.') ?></p>
-				<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+				<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 				<input type="hidden" name="clone_tracker" value="y" />
 				<p><strong><?php echo _('WARNING!!! Cloning this tracker will duplicate all the fields and all the elements from those fields into this tracker. There is nothing to prevent you from cloning multiple times or making a huge mess. You have been warned!') ?></strong></p>
 				<p><?php echo html_build_select_box_from_arrays($ids,$titles,'clone_id','',false); ?></p>

Modified: trunk/gforge/www/tracker/admin/form-deleteextrafield.php
===================================================================
--- trunk/gforge/www/tracker/admin/form-deleteextrafield.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/admin/form-deleteextrafield.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -5,10 +5,10 @@
 		$id = getStringFromRequest('id');
 
 		?>
-		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<p>
-		<input type="hidden" name="deleteextrafield" value="y" /><br />
-		<input type="hidden" name="id" value="<?php echo $id; ?>" /><br />
+		<input type="hidden" name="deleteextrafield" value="y" />
+		<input type="hidden" name="id" value="<?php echo $id; ?>" />
 		<?php echo _('You are about to permanently and irretrievably delete this custom field and all its contents!'); ?>
 		</p>
 		<p>

Modified: trunk/gforge/www/tracker/admin/form-updatecanned.php
===================================================================
--- trunk/gforge/www/tracker/admin/form-updatecanned.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/admin/form-updatecanned.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -16,7 +16,7 @@
 		} else {
 			?>
 			<p><?php echo _('Creating useful generic messages can save you a lot of time when handling common artifact requests.') ?></p>
-			<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+			<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 			<input type="hidden" name="update_canned" value="y" />
 			<input type="hidden" name="id" value="<?php echo $acr->getID(); ?>" />
 			<strong><?php echo _('Title') ?>:</strong><br />

Modified: trunk/gforge/www/tracker/taskmgr.php
===================================================================
--- trunk/gforge/www/tracker/taskmgr.php	2009-10-15 18:50:46 UTC (rev 8283)
+++ trunk/gforge/www/tracker/taskmgr.php	2009-10-15 20:05:21 UTC (rev 8284)
@@ -95,7 +95,7 @@
 		echo '<option value="'.$pt_arr[$i]->getID().'">'.$pt_arr[$i]->getSummary().'</option>';
 	}
 	echo '</select><br />
-		<input type="submit" name="done_adding" value="'._('Add Relationship To Selected Task') . '">
+		<input type="submit" name="done_adding" value="'._('Add Relationship To Selected Task') . '" />
 		</form>';
 
 //




More information about the Fusionforge-commits mailing list