[Fusionforge-commits] r10127 - in trunk/src/www: admin snippet themes/gforge

Alain Peyrat aljeux at libremir.placard.fr.eu.org
Thu Jun 24 23:56:14 CEST 2010


Author: aljeux
Date: 2010-06-24 23:56:13 +0200 (Thu, 24 Jun 2010)
New Revision: 10127

Modified:
   trunk/src/www/admin/configman.php
   trunk/src/www/admin/pluginman.php
   trunk/src/www/snippet/index.php
   trunk/src/www/themes/gforge/Theme.class.php
Log:
More php warnings cleared

Modified: trunk/src/www/admin/configman.php
===================================================================
--- trunk/src/www/admin/configman.php	2010-06-24 21:38:20 UTC (rev 10126)
+++ trunk/src/www/admin/configman.php	2010-06-24 21:56:13 UTC (rev 10127)
@@ -183,7 +183,7 @@
 			// Open readonly but tell you can't write
 			$handle = fopen($filepath,'r');
 			$has_write = false;
-			$feedback .= sprintf(_("Could not open %s file for read/write. Check the permissions for apache."), $filepath).'<br />';
+			$feedback = sprintf(_("Could not open %s file for read/write. Check the permissions for apache."), $filepath).'<br />';
 		}
 		if ($handle){
 			fclose($handle); // we had to open it in r+ because we need to check we'll be able to save it later

Modified: trunk/src/www/admin/pluginman.php
===================================================================
--- trunk/src/www/admin/pluginman.php	2010-06-24 21:38:20 UTC (rev 10126)
+++ trunk/src/www/admin/pluginman.php	2010-06-24 21:56:13 UTC (rev 10127)
@@ -4,7 +4,6 @@
  *
  * @version 
  * @author 
- * @copyright 
  * Copyright 2005 GForge, LLC
  * http://gforge.org/
  *
@@ -178,7 +177,7 @@
 	}
 }
 
-if ($feedback) echo '<div class="feedback">' . $feedback . '</div>';
+if (isset($feedback)) echo '<div class="feedback">' . $feedback . '</div>';
 echo _('Here you can activate / deactivate site-wide plugins which are in the plugins/ folder. Then, you should activate them also per project, per user or whatever the plugin specifically applies to.<br /><span class="important">Be careful because some groups/users can be using the plugin. Deactivating it will remove the plugin from all users/groups.<br />Be <strong>extra</strong> careful not to run the init-script again when the plugin is reactivated, because some scripts have DROP TABLE statements.</span><br /><br />');
 $title_arr = array( _('Plugin Name'),
 		    _('Status'),

Modified: trunk/src/www/snippet/index.php
===================================================================
--- trunk/src/www/snippet/index.php	2010-06-24 21:38:20 UTC (rev 10126)
+++ trunk/src/www/snippet/index.php	2010-06-24 21:56:13 UTC (rev 10127)
@@ -47,8 +47,8 @@
 	$existing_snippets = create_snippet_hash($qpa, "language");
 	for ($i=1; $i<count($SCRIPT_LANGUAGE); $i++) {
 		$return .= '<li>'.util_make_link ('/snippet/browse.php?by=lang&amp;lang='.$i,$SCRIPT_LANGUAGE[$i]).' (';
-		// Remove warning
-		if (@$existing_snippets[$i]) {
+
+		if (isset($existing_snippets[$i])) {
 			$return .= $existing_snippets[$i].')</li>';
 		} else {
 			$return .= '0)</li>';
@@ -65,8 +65,8 @@
 	for ($i=1; $i<count($SCRIPT_CATEGORY); $i++) {
 		// Remove warning
 		@$return .= '<li>'.util_make_link ('/snippet/browse.php?by=cat&amp;cat='.$i,$SCRIPT_CATEGORY[$i]).' (';
-		// Remove warning
-		if (@$existing_categories[$i]) {
+
+		if (isset($existing_categories[$i])) {
 			$return .= $existing_categories[$i].')</li>';
 		} else {
 			$return .= '0)</li>';

Modified: trunk/src/www/themes/gforge/Theme.class.php
===================================================================
--- trunk/src/www/themes/gforge/Theme.class.php	2010-06-24 21:38:20 UTC (rev 10126)
+++ trunk/src/www/themes/gforge/Theme.class.php	2010-06-24 21:56:13 UTC (rev 10127)
@@ -355,7 +355,7 @@
 		$return= '
         <tr class="ff" '.$row_attr;
 		if ( $istitle ) {
-			$return .=' align="center" bgcolor="'. $this->COLOR_HTMLBOX_TITLE .'"';
+			$return .=' align="center"';
 		}
 		$return .= '>';
 		for ( $c = 0; $c < count($cell_data); $c++ ) {
@@ -365,11 +365,11 @@
 			}
 			$return .= '>';
 			if ( $istitle ) {
-				$return .='<font color="'.$this->FONTCOLOR_HTMLBOX_TITLE.'"><strong>';
+				$return .='<strong>';
 			}
 			$return .= $cell_data[$c][0];
 			if ( $istitle ) {
-				$return .='</strong></font>';
+				$return .='</strong>';
 			}
 			$return .= '</td>';
 




More information about the Fusionforge-commits mailing list