[Fusionforge-commits] r13011 - branches/Branch_5_1/src/plugins/cvstracker/common

Alain Peyrat aljeux at fusionforge.org
Sun Apr 3 20:40:49 CEST 2011


Author: aljeux
Date: 2011-04-03 20:40:48 +0200 (Sun, 03 Apr 2011)
New Revision: 13011

Modified:
   branches/Branch_5_1/src/plugins/cvstracker/common/cvstrackerPlugin.class.php
Log:
Hide cvstracker plugin option if cvs is not active & refactor code

Modified: branches/Branch_5_1/src/plugins/cvstracker/common/cvstrackerPlugin.class.php
===================================================================
--- branches/Branch_5_1/src/plugins/cvstracker/common/cvstrackerPlugin.class.php	2011-04-03 18:24:56 UTC (rev 13010)
+++ branches/Branch_5_1/src/plugins/cvstracker/common/cvstrackerPlugin.class.php	2011-04-03 18:40:48 UTC (rev 13011)
@@ -42,6 +42,13 @@
 		$this->hooks[] = "get_cvs_loginfo_lines";
 	}
 
+	function groupisactivecheckbox (&$params) {
+		$group = group_get_object($params['group']);
+		if ($group->usesPlugin('scmcvs')) {
+			parent::groupisactivecheckbox($params);
+		}
+	}
+
 	/**
 	* It display a table with commit related to this tracker or task_extra_detail
 	*
@@ -259,34 +266,9 @@
 	*
 	*/
 	function CallHook ($hookname, &$params) {
-		global $group_id, $G_SESSION, $HTML, $use_cvstrackerplugin,$aid ;
-		$use_cvstrackerplugin = getIntFromRequest('use_cvstrackerplugin');
-		if ($hookname == "groupisactivecheckbox") {
-			//Check if the group is active
-			$group = group_get_object($group_id);
-			if ($group->usesPlugin('scmcvs')) {
-				echo "<tr>";
-				echo "<td>";
-				echo ' <input type="checkbox" name="use_cvstrackerplugin" value="1" ';
-				// checked or unchecked?
-				if ( $group->usesPlugin ( $this->name ) ) {
-					echo "checked";
-				}
-				echo "><br/>";
-				echo "</td>";
-				echo "<td>";
-				echo "<strong>Use ".$this->text." Plugin</strong>";
-				echo "</td>";
-				echo "</tr>";
-			}
-		} elseif ($hookname == "groupisactivecheckboxpost") {
-			$group = group_get_object($group_id);
-			if ( $use_cvstrackerplugin == 1 ) {
-				$group->setPluginUse ( $this->name );
-			} else {
-				$group->setPluginUse ( $this->name, false );
-			}
-		} elseif ($hookname == "artifact_extra_detail") {
+		global $group_id, $G_SESSION, $HTML, $aid ;
+
+		if ($hookname == "artifact_extra_detail") {
 			$DBResult = db_query_params ('SELECT * FROM plugin_cvstracker_data_master,plugin_cvstracker_data_artifact WHERE plugin_cvstracker_data_artifact.group_artifact_id=$1 AND plugin_cvstracker_data_master.holder_id=plugin_cvstracker_data_artifact.id ORDER BY cvs_date',
 						     array ($aid)) ;
 			$this->getCommitEntries($DBResult, $group_id);




More information about the Fusionforge-commits mailing list