[Fusionforge-commits] r15340 - in trunk/src/plugins/mantisbt: . action common view view/admin www/admin www/scripts

Franck VILLAUME nerville at fusionforge.org
Sat Apr 14 14:42:05 CEST 2012


Author: nerville
Date: 2012-04-14 14:42:03 +0200 (Sat, 14 Apr 2012)
New Revision: 15340

Modified:
   trunk/src/plugins/mantisbt/
   trunk/src/plugins/mantisbt/action/addAttachment.php
   trunk/src/plugins/mantisbt/action/addCategory.php
   trunk/src/plugins/mantisbt/action/addIssue.php
   trunk/src/plugins/mantisbt/action/addNote.php
   trunk/src/plugins/mantisbt/action/addVersion.php
   trunk/src/plugins/mantisbt/action/deleteAttachment.php
   trunk/src/plugins/mantisbt/action/deleteCategory.php
   trunk/src/plugins/mantisbt/action/deleteVersion.php
   trunk/src/plugins/mantisbt/action/init.php
   trunk/src/plugins/mantisbt/action/renameCategory.php
   trunk/src/plugins/mantisbt/action/updateConf.php
   trunk/src/plugins/mantisbt/action/updateIssue.php
   trunk/src/plugins/mantisbt/action/updateNote.php
   trunk/src/plugins/mantisbt/action/updateVersion.php
   trunk/src/plugins/mantisbt/action/updateuserConf.php
   trunk/src/plugins/mantisbt/common/MantisBTPlugin.class.php
   trunk/src/plugins/mantisbt/view/admin/addVersion.php
   trunk/src/plugins/mantisbt/view/admin/editVersion.php
   trunk/src/plugins/mantisbt/view/admin/viewConfiguration.php
   trunk/src/plugins/mantisbt/view/init.php
   trunk/src/plugins/mantisbt/www/admin/index.php
   trunk/src/plugins/mantisbt/www/scripts/MantisBTController.js
Log:
port from branch 5.2 : cleanup mantisbt


Property changes on: trunk/src/plugins/mantisbt
___________________________________________________________________
Added: svn:mergeinfo
   + /branches/Branch_4_7/src/plugins/mantisbt:6879,6881,6884,6897,6899,6902,6904,6906,6909,6911,6922,6932,6936,6939,6942,6944,6946-6948,6954,6956,6959,7000-7001,7012,7111,7130-7131,7133-7134,7138,7140-7142,7147-7148,7159-7160,7163,7168,7177,7179,7203,7205,7207,7210,7212,7251-7253,7255,7284,7287,7291,7293,7295-7296,7300,7355,7365-7366,7375-7376,7378,7395,7423-7426,7435,7458,7504,7567,7577,7623-7624,7638,7659-7660,7662,7665,7668,7674,7699,7746-7748,7771,7774,7786,7838
/branches/Branch_4_8/src/plugins/mantisbt:7334-7335,7344-7345,7382,7387,7389-7390,7396,7398,7401-7402,7428-7429,7437,7440,7443,7449-7455,7459,7462,7466,7469-7470,7476-7478,7480,7485,7490-7492,7505,7540,7556-7560,7568,7570-7571,7573,7576,7580,7609-7611,7613,7615,7618,7621-7622,7625-7627,7639,7658,7661,7663-7664,7666-7667,7673,7675,7678,7680,7685,7688-7689,7693,7700,7706-7708,7713,7725,7728-7742,7760,7763-7764,7767,7769-7770,7773,7776,7784-7785,7791,7797,7799,7802-7808,7810-7811,7816,7818,7825-7828,7839,7846-7847,7850,7894,7902,7920-7922,7927-7928,7932,7936-7937,7939,7942,7944-7945,7947,7951,7956,7958,7960,8064,8079-8080,8108,8113,8119,8121,8127-8128,8145,8197,8201-8202,8216,8224,8226,8228,8247-8250,8252,8271-8272,8310-8311,8328,8337,8339-8357,8361,8371,8373-8375,8378-8379,8383-8396,8415,8427-8431,8438-8441,8449,8452-8453,8458,8461,8477-8478,8480,8482,8492,8514,8530,8604-8605,8608,8637,8662,8674,8751,8754,8756,8760-8761,8812,8850,8945,8995,8998,9004-9006,9124,9137,9141,9317,9443,9469,9670,9701,9726,9934,10013,10310,10314,10366,12790,13085
/branches/Branch_5_0/src/plugins/mantisbt:8892,8895,8897-8898,8900,8903-8904,8906-8907,8910,8915,8922,8924,8926,8929,8931-8933,8941,8946,8951,8955,8972-8977,8981,8997,8999,9002,9031-9032,9050,9080-9081,9084-9086,9093-9095,9102-9104,9108,9113-9115,9117-9118,9123,9125,9127-9131,9135-9136,9139,9146,9148-9150,9179-9191,9193-9195,9198,9200,9202,9204,9207,9209,9211,9213,9215,9220-9222,9231,9234-9235,9243,9251,9254,9259,9287,9315,9318,9347-9349,9358,9396,9427,9429,9431-9433,9441-9442,9444-9445,9462,9464,9468,9522-9523,9549,9551-9552,9576-9577,9579,9615,9633-9634,9672-9673,9675-9676,9684,9686-9687,9689,9699,9727,9729,9731,9930-9932,9935,9956,9980,10005-10006,10021,10024,10027,10064,10081-10082,10273,10285,10820-10824,10868,10872,10876-10878,10880,10918,11015,11017,11058-11060,11085-11086,11160-11165,11252-11253,11287,11294,11581,11619-11620,11679,11722-11723,11907,11974,12789,12940,12986,13023-13024,13086,13121-13122,13162,13465,13496,13501,13503,13660
/branches/Branch_5_1/src/plugins/mantisbt:11607-11609,11621,11625,11627,11631,11638,11644,11647-11651,11677,11680-11681,11683-11684,11719-11720,11724,11754,11780,11783,11792,11794,11802,11808-11816,11818,11822-11824,11827-11829,11834-11835,11847,11849,11851-11852,11855,11858,11862,11867,11869-11872,11876,11880,11893,11902-11905,11915,11923-11927,11929-11930,11932,11934-11941,11943,11948-11949,11952-11954,11956-11960,11962,11965-11966,11972,11975,11980,11983-11984,11986-11987,11990,11992-11997,12003-12004,12010-12013,12015,12018-12024,12043-12044,12046-12061,12063,12065,12070,12073-12076,12081-12083,12093-12094,12102,12105,12118,12124,12127-12128,12139,12141,12143,12148-12149,12153,12157-12159,12168-12169,12175-12180,12190,12194-12198,12203,12208-12213,12217-12258,12262,12264-12266,12274-12277,12281-12282,12287-12290,12340,12345-12346,12352,12359,12472-12473,12594,12634,12636-12638,12658-12659,12684-12712,12714-12715,12733,12780-12783,12785-12786,12795,12797,12800-12802,12815-12816,12840-12856,12860,12882-12883,12888-12892,12897,12904,12914-12917,12922-12926,12929-12936,12939,12959-12965,12967-12971,13011,13022,13025,13031-13032,13034,13043-13046,13048-13050,13053,13056,13058,13061,13068-13070,13075,13088,13090-13091,13101,13103-13104,13106,13108-13109,13111-13114,13116-13117,13120,13125,13127-13128,13148,13153-13161,13163,13165-13166,13174-13175,13188,13190,13211-13212,13219,13221,13231-13234,13236-13238,13253,13257-13270,13272-13274,13287-13300,13302-13342,13355-13374,13377-13379,13386-13389,13391-13400,13404,13408,13410,13412,13415-13416,13420,13422-13426,13429-13432,13452,13456,13461-13464,13466,13468-13470,13472-13477,13492,13517-13519,13527-13532,13589-13590,13624-13628,13645,13661-13663,13666,13684,13689-13690,13697,13699,13704,13745,13761,13766-13767,13769-13770,13772-13801,13808,13817-13818,13820-13823,13830-13831,13838,13854,13861,13984,13986-13988,14009,14013-14015,14020-14021,14036,14039-14045,14047,14051-14053,14056-14059,14065,14072,14080-14084,14086-14090,14095-14099,14101-14121,14130-14136,14162-14167,14172-14173,14184,14215-14220,14238-14241,14266-14269,14273-14278,14285,14288-14289,14303,14305,14307,14309,14311,14313-14316,14318-14320,14322,14358,14391-14392,14444-14446,14461-14462,14472,14476-14480,14496,14498,14505-14506,14511,14515,14538-14554,14558-14574,14577-14578,14582-14597,14599-14602,14614-14616,14686-14687,14698,14702,14705,14736,14738,14740,14742-14743,14747,14784-14786,14802-14809,14812-14813,14898-14904,14908-14909,14929-14931,15014-15015,15024-15028,15032,15044-15049,15056-15058,15070,15081-15082,15087,15092-15095,15121-15125,15128-15135,15138-15139,15141,15144,15147-15148,15169-15173,15175,15182,15186-15188,15190,15223,15238,15282,15304,15330
/branches/Branch_5_2/src/plugins/mantisbt:15217,15219,15221,15224,15227-15229,15234,15239,15279,15284-15339
/branches/tracker_attachement_move_in_fs/src/plugins/mantisbt:14977-14978
/shelves/alain_peyrat/src/plugins/mantisbt:14997-15003
/shelves/aljeux/src/plugins/mantisbt:15005,15012,15150,15154-15160,15177-15179,15203,15232,15276-15277,15306
/trunk/src/plugins/mantisbt:8721-8727

Modified: trunk/src/plugins/mantisbt/action/addAttachment.php
===================================================================
--- trunk/src/plugins/mantisbt/action/addAttachment.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/addAttachment.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -33,7 +33,7 @@
 		$clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 
 	$clientSOAP->__soapCall('mc_issue_attachment_add', array("username" => $username, "password" => $password, "issue_id" => $idBug, "name" => $_FILES['attachment']['name'], "file_type" => $_FILES['attachment']['type'], "content" => file_get_contents($_FILES['attachment']['tmp_name'])));
-	$feedback = _('Task succeeded');
+	$feedback = _('Task succeeded.');
 } catch (SoapFault $soapFault) {
 	$error_msg = _('Task failed')._(': ').$soapFault->faultstring;
 	session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&error_msg='.urlencode($error_msg));

Modified: trunk/src/plugins/mantisbt/action/addCategory.php
===================================================================
--- trunk/src/plugins/mantisbt/action/addCategory.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/addCategory.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -28,7 +29,7 @@
 global $password;
 global $group_id;
 
-$nameCategory = $_POST['nameCategory'];
+$nameCategory = getStringFromRequest('nameCategory');
 
 if (!empty($nameCategory)) {
 	try {

Modified: trunk/src/plugins/mantisbt/action/addIssue.php
===================================================================
--- trunk/src/plugins/mantisbt/action/addIssue.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/addIssue.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT Plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -30,7 +31,7 @@
 
 $defect = array();
 
-$defect['category'] = $_POST['categorie'];
+$defect['category'] = getStringFromRequest('categorie');
 $defect['project']['id'] = $mantisbtConf['id_mantisbt'];
 
 try {
@@ -47,7 +48,7 @@
 	session_redirect('plugins/mantisbt/?type='.$type.'&group_id='.$group_id.'&pluginname=mantisbt&view=viewIssues&error_msg='.urlencode($feedback));
 }
 foreach($listSeverities as $key => $severity){
-	if ($_POST['severite'] == $severity->name){
+	if (getStringFromRequest('severite') == $severity->name){
 		$defect['severity']['id'] = $severity->id;
 		$defect['severity']['name'] = $severity->name;
 		break;
@@ -55,7 +56,7 @@
 }
 
 foreach($listReproducibilities as $key => $reproducibility){
-	if ($_POST['reproductibilite'] == $reproducibility->name){
+	if (getStringFromRequest('reproductibilite') == $reproducibility->name){
 		$defect['reproducibility']['id'] = $reproducibility->id;
 		$defect['reproducibility']['name'] = $reproducibility->name;
 		break;
@@ -79,10 +80,10 @@
 	}
 }
 
-if ($_POST['handler'] != ''){
+if (getStringFromRequest('handler') != ''){
 	$listUsers = $clientSOAP->__soapCall('mc_project_get_users', array("username" => $username, "password" => $password, "project_id" => $idProjetMantis, "acces" => 10));
 	foreach($listUsers as $key => $mantisuser){
-		if ($_POST['handler'] == $mantisuser->name){
+		if (getStringFromRequest('handler') == $mantisuser->name){
 			$defect['handler']['id'] = $mantisuser->id;
 			$defect['handler']['name'] = $mantisuser->name;
 			$defect['handler']['email'] = $mantisuser->email;
@@ -92,7 +93,7 @@
 }
 
 foreach($listPriorities as $key => $priority){
-	if ($_POST['priorite'] == $priority->name){
+	if (getStringFromRequest('priorite') == $priority->name){
 		$defect['priority']['id'] = $priority->id;
 		$defect['priority']['name'] = $priority->name;
 		break;
@@ -115,21 +116,14 @@
 	}
 }
 
-$defect['description'] = $_POST['description'];
-$defect['summary'] = $_POST['resume'];
+$defect['description'] = getStringFromRequest('description');
+$defect['summary'] = getStringFromRequest('resume');
+$defect['additional_information'] = getStringFromRequest('informations');
+$defect['version'] = getStringFromRequest('version');
 
-
-if (isset($_POST['informations'])){
-	$defect['additional_information'] = $_POST['informations'];
-}
-
-if (isset($_POST['version'])) {
-	$defect['version'] = $_POST['version'];
-}
-
 try {
 	$newIdBug = $clientSOAP->__soapCall('mc_issue_add', array("username" => $username, "password" => $password, "issue" => $defect));
-	$feedback = _('Ticket '.$newIdBug.' created successfully');
+	$feedback = _('Ticket '.$newIdBug.' created successfully.');
 	session_redirect('plugins/mantisbt/?type='.$type.'&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$newIdBug.'&view=viewIssue&feedback='.urlencode($feedback));
 } catch (SoapFault $soapFault) {
 	$error_msg = _('Task failed')._(': ').$soapFault->faultstring;

Modified: trunk/src/plugins/mantisbt/action/addNote.php
===================================================================
--- trunk/src/plugins/mantisbt/action/addNote.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/addNote.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -31,7 +32,7 @@
 	$clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 	$noteEdit;
 
-	$note['text'] = $_POST['edit_texte_note'];
+	$note['text'] = getStringFromRequest('edit_texte_note');
 
 	$note['view_state']['id'] = 10;
 	$listViewStates = $clientSOAP->__soapCall('mc_enum_view_states', array("username" => $username, "password" => $password));
@@ -53,7 +54,7 @@
 	}
 
 	$clientSOAP->__soapCall('mc_issue_note_add', array("username" => $username, "password" => $password, "issue_id" => $idBug, "note" => $note));
-	$feedback = _('Note added successfully');
+	$feedback = _('Note added successfully.');
 } catch (SoapFault $soapFault) {
 	$error_msg = _('Task failed')._(': ').$soapFault->faultstring;
 	session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&error_msg='.urlencode($error_msg));

Modified: trunk/src/plugins/mantisbt/action/addVersion.php
===================================================================
--- trunk/src/plugins/mantisbt/action/addVersion.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/addVersion.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -28,38 +29,40 @@
 global $group_id;
 
 /* addVersion action page */
-if (isset($_POST['version']) && !empty($_POST['version'])) {
+$version = getStringFromRequest('version');
+if (!empty($version)) {
 	$versionStruct = array();
-	$versionStruct['name'] = $_POST['version'];
+	$versionStruct['name'] = $version;
 	$versionStruct['project_id'] = $mantisbtConf['id_mantisbt'];
 	$versionStruct['released'] = 0;
-	$versionStruct['description'] = $_POST['description'];
+	$versionStruct['description'] = getStringFromRequest('description');
 	$versionStruct['date_order'] = '';
 	try {
 		if (!isset($clientSOAP))
 			$clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 
 		$clientSOAP->__soapCall('mc_project_version_add', array("username" => $username, "password" => $password, "version" => $versionStruct));
-		if (isset($_POST['transverse'])) {
-			$listChild = $clientSOAP->__soapCall('mc_project_get_all_subprojects', array("username" => $username, "password" => $password, "project_id" => $idProjetMantis));
-			foreach ($listChild as $key => $child) {
-				$listVersions = $clientSOAP->__soapCall('mc_project_get_versions', array("username" => $username, "password" => $password, "project_id" => $child));
-				$todo = 1;
-				foreach ($listVersions as $key => $version ) {
-					if ($version->name == $versionStruct['name'])
-						$todo = 0;
-				}
-				if ($todo) {
-					try {
-						$versionStruct['project_id'] = $child;
-						$clientSOAP->__soapCall('mc_project_version_add', array("username" => $username, "password" => $password, "version" => $versionStruct));
-					} catch (SoapFault $soapFault) {
-						$msg = _('Task failed')._(': ').$versionStruct['name'].' '.$soapFault->faultstring;
-						session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($msg));
-					}
-				}
-			}
-		}
+		// currently transverse is not implemented... need to rely on projects-hierarchy plugin.
+// 		if (isset($_POST['transverse'])) {
+// 			$listChild = $clientSOAP->__soapCall('mc_project_get_all_subprojects', array("username" => $username, "password" => $password, "project_id" => $idProjetMantis));
+// 			foreach ($listChild as $key => $child) {
+// 				$listVersions = $clientSOAP->__soapCall('mc_project_get_versions', array("username" => $username, "password" => $password, "project_id" => $child));
+// 				$todo = 1;
+// 				foreach ($listVersions as $key => $version ) {
+// 					if ($version->name == $versionStruct['name'])
+// 						$todo = 0;
+// 				}
+// 				if ($todo) {
+// 					try {
+// 						$versionStruct['project_id'] = $child;
+// 						$clientSOAP->__soapCall('mc_project_version_add', array("username" => $username, "password" => $password, "version" => $versionStruct));
+// 					} catch (SoapFault $soapFault) {
+// 						$msg = _('Task failed')._(': ').$versionStruct['name'].' '.$soapFault->faultstring;
+// 						session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($msg));
+// 					}
+// 				}
+// 			}
+// 		}
 	} catch (SoapFault $soapFault) {
 		$msg = _('Task failed')._(': ').$versionStruct['name'].' '.$soapFault->faultstring;
 		session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($msg));

Modified: trunk/src/plugins/mantisbt/action/deleteAttachment.php
===================================================================
--- trunk/src/plugins/mantisbt/action/deleteAttachment.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/deleteAttachment.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -33,13 +33,13 @@
 	try {
 		$clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 		$clientSOAP->__soapCall('mc_issue_attachment_delete', array("username" => $username, "password" => $password, "issue_attachment_id" => $idAttachment));
-		$feedback = _('Attachment deleted successfully');
+		$feedback = _('Attachment deleted successfully.');
 	} catch (SoapFault $soapFault) {
 		$error_msg = _('Task failed')._(': ').$soapFault->faultstring;
 		session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&error_msg='.urlencode($error_msg));
 	}
 	session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&feedback='.urlencode($feedback));
 }
-$warning_msg = _('Missing Attachment ID to delete');
+$warning_msg = _('Missing Attachment ID to delete.');
 session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&warning_msg='.urlencode($warning_msg));
 ?>

Modified: trunk/src/plugins/mantisbt/action/deleteCategory.php
===================================================================
--- trunk/src/plugins/mantisbt/action/deleteCategory.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/deleteCategory.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -26,20 +27,20 @@
 global $username;
 global $password;
 
-$deleteCategory = $_POST['deleteCategory'];
+$deleteCategory = getStringFromRequest('deleteCategory');
 
 if ($deleteCategory) {
     try {
 	    $clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 	    $clientSOAP->__soapCall('mc_project_delete_category', array("username" => $username, "password" => $password, "p_project_id" => $mantisbtConf['id_mantisbt'], "p_category_name" => $deleteCategory));
     } catch (SoapFault $soapFault) {
-        $msg = _('Error')._(': ').$soapFault->faultstring;
+        $msg = _('Task failed:').' '.$soapFault->faultstring;
         session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($msg));
     }
-    $feedback = sprintf(_('Category %s deleted successfully'), $deleteCategory);
+    $feedback = sprintf(_('Category %s deleted successfully.'), $deleteCategory);
     session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&feedback='.urlencode($feedback));
 } else {
-    $warning = _('Missing parameters to delete category');
+    $warning = _('Missing parameters to delete category.');
     session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&warning_msg='.urlencode($warning));
 }
 ?>

Modified: trunk/src/plugins/mantisbt/action/deleteVersion.php
===================================================================
--- trunk/src/plugins/mantisbt/action/deleteVersion.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/deleteVersion.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -29,21 +30,21 @@
 global $password;
 global $group_id;
 
-$deleteVersion = $_POST['deleteVersion'];
+$deleteVersion = getIntFromRequest('deleteVersion');
 
-if ($deleteVersion) {
+if (!empty($deleteVersion)) {
 	try {
 		if(!isset($clientSOAP))
 			$clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 	    $clientSOAP->__soapCall('mc_project_version_delete', array("username" => $username, "password" => $password, "version_id" => $deleteVersion));
 	} catch (SoapFault $soapFault) {
-		$msg = _('Error')._(': ').$soapFault->faultstring;
+		$msg = _('Task failed:').' '.$soapFault->faultstring;
 		session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($msg));
 	}
-	$feedback = _('Version deleted successfully');
+	$feedback = _('Version deleted successfully.');
 	session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&feedback='.urlencode($feedback));
 } else {
-	$warning = _('Missing parameters to delete version');
+	$warning = _('Missing parameters to delete version.');
 	session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&warning_msg='.urlencode($warning));
 }
 ?>

Modified: trunk/src/plugins/mantisbt/action/init.php
===================================================================
--- trunk/src/plugins/mantisbt/action/init.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/init.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -26,6 +27,7 @@
 global $group; // the group object
 
 $confArr = array();
+$confArr['globalconf'] = getIntFromRequest('global_conf');
 $confArr['url'] = getStringFromRequest('url');
 $confArr['sync_roles'] = 0;
 $confArr['soap_user'] = getStringFromRequest('soap_user');

Modified: trunk/src/plugins/mantisbt/action/renameCategory.php
===================================================================
--- trunk/src/plugins/mantisbt/action/renameCategory.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/renameCategory.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -28,20 +29,24 @@
 global $password;
 global $group_id;
 
-$newCategoryName = $_POST['newCategoryName'];
-$renameCategory = $_POST['renameCategory'];
+$newCategoryName = trim(getStringFromRequest('newCategoryName'));
+$renameCategory = getStringFromRequest('renameCategory');
 
-if ( $newCategoryName && $renameCategory ) {
+if ($newCategoryName && $renameCategory) {
+	if ( $newCategoryName === $renameCategory ) {
+		$warning_msg = _('No action, same category name.');
+		session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&warning_msg='.urlencode($warning_msg));
+	}
 	try {
 		$clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 		$clientSOAP->__soapCall('mc_project_rename_category_by_name', array("username" => $username, "password" => $password, "p_project_id" => $mantisbtConf['id_mantisbt'], "p_category_name" => $renameCategory, "p_category_name_new" => $newCategoryName, "p_assigned_to" => ''));
 	} catch (SoapFault $soapFault) {
-		$msg = _('Error')._(': ').$soapFault->faultstring;
+		$msg = _('Task failed:').' '.$soapFault->faultstring;
 		session_redirect('plugins/mantisbt/?type=admin&id='.$id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($msg));
 	}
-	$feedback = _('Category renamed successfully');
+	$feedback = _('Category renamed successfully.');
 	session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&feedback='.urlencode($feedback));
 }
-$warning_msg = _('Missing category name');
-session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&warning_msg='.urlencode($warning));
+$warning_msg = _('Missing category name.');
+session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&warning_msg='.urlencode($warning_msg));
 ?>

Modified: trunk/src/plugins/mantisbt/action/updateConf.php
===================================================================
--- trunk/src/plugins/mantisbt/action/updateConf.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/updateConf.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,7 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2011, Franck Villaume - Capgemini
- * Copyright 2011, Franck Villaume - TrivialDev
+ * Copyright 2011-2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -31,9 +31,7 @@
 $confArr['sync_roles'] = 0;
 $confArr['soap_user'] = getStringFromRequest('soap_user');
 $confArr['soap_password'] = getStringFromRequest('soap_password');
-$confArr['global_conf'] = 0;
-if (getStringFromRequest('global_conf'))
-	$confArr['global_conf'] = 1;
+$confArr['global_conf'] = getIntFromRequest('global_conf');
 
 if (!$mantisbt->updateConf($group_id, $confArr))
 	session_redirect('/plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($group->getErrorMessage()));

Modified: trunk/src/plugins/mantisbt/action/updateIssue.php
===================================================================
--- trunk/src/plugins/mantisbt/action/updateIssue.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/updateIssue.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -42,21 +42,21 @@
 		break;
 	}
 	default: {
-		$error_msg = _('No type found');
+		$error_msg = _('No type found.');
 		session_redirect('plugins/mantisbt/&error_msg='.urlencode($error_msg));
 	}
 }
 
 $clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
 $defect = $clientSOAP->__soapCall('mc_issue_get', array("username" => $username, "password" => $password, "issue_id" => $idBug));
-if ($defect->category != $_POST['categorie']) {
-	$defect->category = $_POST['categorie'];
+if ($defect->category != getStringFromRequest('categorie')) {
+	$defect->category = getStringFromRequest('categorie');
 }
 
-if ($defect->severity->name != $_POST['severite']) {
+if ($defect->severity->name != getStringFromRequest('severite')) {
 	$listSeverities = $clientSOAP->__soapCall('mc_enum_severities', array("username" => $username, "password" => $password));
 	foreach($listSeverities as $key => $severity) {
-		if ($_POST['severite'] == $severity->name) {
+		if (getStringFromRequest('severite') == $severity->name) {
 			$defect->severity->id = $severity->id;
 			$defect->severity->name = $severity->name;
 			break;
@@ -64,10 +64,10 @@
 	}
 }
 
-if ($defect->reproducibility->name != $_POST['reproductibilite']) {
+if ($defect->reproducibility->name != getStringFromRequest('reproductibilite')) {
 	$listReproducibilities = $clientSOAP->__soapCall('mc_enum_reproducibilities', array("username" => $username, "password" => $password));
 	foreach($listReproducibilities as $key => $reproducibility) {
-		if ($_POST['reproductibilite'] == $reproducibility->name) {
+		if (getStringFromRequest('reproductibilite') == $reproducibility->name) {
 			$defect->reproducibility->id = $reproducibility->id;
 			$defect->reproducibility->name = $reproducibility->name;
 			break;
@@ -75,10 +75,10 @@
 	}
 }
 
-if ($defect->reporter->name != $_POST['reporter']) {
+if ($defect->reporter->name != getStringFromRequest('reporter')) {
 	$listUsers = $clientSOAP->__soapCall('mc_project_get_users', array("username" => $username, "password" => $password, "project_id" => $defect->project->id, "acces" => 10));
 	foreach($listUsers as $key => $usermantis) {
-		if ($_POST['reporter'] == $usermantis->name) {
+		if (getStringFromRequest('reporter') == $usermantis->name) {
 			$defect->reporter->id = $usermantis->id;
 			$defect->reporter->name = $usermantis->name;
 			$defect->reporter->real_name = $usermantis->real_name;
@@ -88,10 +88,10 @@
 	}
 }
 
-if ($defect->view_state->name != $_POST['viewstate']) {
+if ($defect->view_state->name != getStringFromRequest('viewstate')) {
 	$listViewStates = $clientSOAP->__soapCall('mc_enum_view_states', array("username" => $username, "password" => $password));
 	foreach($listViewStates as $key => $viewState) {
-		if ($_POST['viewstate'] == $viewState->name) {
+		if (getStringFromRequest('viewstate') == $viewState->name) {
 			$defect->view_state->id = $viewState->id;
 			$defect->view_state->name = $viewState->name;
 			break;
@@ -99,11 +99,11 @@
 	}
 }
 
-if ($defect->handler->name != $_POST['handler']) {
-	if ($_POST['handler'] != ""){
+if ($defect->handler->name != getStringFromRequest('handler')) {
+	if (getStringFromRequest('handler') != ""){
 		$listUsers = $clientSOAP->__soapCall('mc_project_get_users', array("username" => $username, "password" => $password, "project_id" => $defect->project->id, "acces" => 10));
 		foreach($listUsers as $key => $usermantis) {
-			if ($_POST['handler'] == $usermantis->name) {
+			if (getStringFromRequest('handler') == $usermantis->name) {
 				$defect->handler->id = $usermantis->id;
 				$defect->handler->name = $usermantis->name;
 				$defect->handler->real_name = $usermantis->real_name;
@@ -116,10 +116,10 @@
 	}
 }
 
-if ($defect->priority->name != $_POST['priorite']) {
+if ($defect->priority->name != getStringFromRequest('priorite')) {
 	$listPriorities = $clientSOAP->__soapCall('mc_enum_priorities', array("username" => $username, "password" => $password));
 	foreach($listPriorities as $key => $priority) {
-		if ($_POST['priorite'] == $priority->name) {
+		if (getStringFromRequest('priorite') == $priority->name) {
 			$defect->priority->id = $priority->id;
 			$defect->priority->name = $priority->name;
 			break;
@@ -127,10 +127,10 @@
 	}
 }
 
-if ($defect->resolution->name != $_POST['resolution']) {
+if ($defect->resolution->name != getStringFromRequest('resolution')) {
 	$listResolutions= $clientSOAP->__soapCall('mc_enum_resolutions', array("username" => $username, "password" => $password));
 	foreach($listResolutions as $key => $resolution) {
-		if ($_POST['resolution'] == $resolution->name) {
+		if (getStringFromRequest('resolution') == $resolution->name) {
 			$defect->resolution->id = $resolution->id;
 			$defect->resolution->name = $resolution->name;
 			break;
@@ -138,10 +138,10 @@
 	}
 }
 
-if ($defect->status->name != $_POST['etat']) {
+if ($defect->status->name != getStringFromRequest('etat')) {
 	$listStatus= $clientSOAP->__soapCall('mc_enum_status', array("username" => $username, "password" => $password));
 	foreach($listStatus as $key => $status) {
-		if ($_POST['etat'] == $status->name) {
+		if (getStringFromRequest('etat') == $status->name) {
 			$defect->status->id = $status->id;
 			$defect->status->name = $status->name;
 			break;
@@ -149,28 +149,28 @@
 	}
 }
 
-if ($defect->description != $_POST['description']) {
-	$defect->description = $_POST['description'];
+if ($defect->description != getStringFromRequest('description')) {
+	$defect->description = getStringFromRequest('description');
 }
 
-if ($defect->additional_information != $_POST['informations']) {
-	$defect->additional_information = $_POST['informations'];
+if ($defect->additional_information != getStringFromRequest('informations')) {
+	$defect->additional_information = getStringFromRequest('informations');
 }
 
-if ($defect->summary != $_POST['resume']){
-	$defect->summary = $_POST['resume'];
+if ($defect->summary != getStringFromRequest('resume')){
+	$defect->summary = getStringFromRequest('resume');
 }
 
-if ($defect->version != $_POST['version']) {
-	$defect->version = $_POST['version'];
+if ($defect->version != getStringFromRequest('version')) {
+	$defect->version = getStringFromRequest('version');
 }
 
-if ($defect->fixed_in_version != $_POST['fixed_in_version']) {
-	$defect->fixed_in_version = $_POST['fixed_in_version'];
+if ($defect->fixed_in_version != getStringFromRequest('fixed_in_version')) {
+	$defect->fixed_in_version = getStringFromRequest('fixed_in_version');
 }
 
-if ($defect->target_version != $_POST['target_version']) {
-	$defect->target_version = $_POST['target_version'];
+if ($defect->target_version != getStringFromRequest('target_version')) {
+	$defect->target_version = getStringFromRequest('target_version');
 }
 
 try {
@@ -180,7 +180,7 @@
 	session_redirect($redirect_url.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&error_msg='.urlencode($feedback));
 }
 
-$feedback = _('Task succeeded');
+$feedback = _('Task succeeded.');
 session_redirect($redirect_url.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&feedback='.urlencode($feedback));
 
 ?>

Modified: trunk/src/plugins/mantisbt/action/updateNote.php
===================================================================
--- trunk/src/plugins/mantisbt/action/updateNote.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/updateNote.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -44,9 +45,7 @@
 	}
 }
 
-if (isset($_POST['edit_texte_note'])){
-	$noteEdit->text = $_POST['edit_texte_note'];
-}
+$noteEdit->text = getStringFromRequest('edit_texte_note');
 
 foreach($listViewStates as $state){
 	if (($state->id == 50 && $actionNote == "private") || ($state->id == 10 && $actionNote == "public")){
@@ -63,7 +62,7 @@
 	session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&error_msg='.urlencode($error_msg));
 }
 
-$feedback = _('Task succeeded');
+$feedback = _('Task succeeded.');
 session_redirect('plugins/mantisbt/?type=group&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&idBug='.$idBug.'&view=viewIssue&feedback='.urlencode($feedback));
 
 ?>

Modified: trunk/src/plugins/mantisbt/action/updateVersion.php
===================================================================
--- trunk/src/plugins/mantisbt/action/updateVersion.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/updateVersion.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -28,40 +29,37 @@
 global $password;
 global $group_id;
 
-$version_id = $_POST['version_id'];
+$version_id = getIntFromRequest('version_id');
 
 $version_data = array();
-if ( $_POST['version_release'] == 1 ) {
-	$version_data['released'] = 1;
-} else {
-	$version_data['released'] = 0;
-}
+$version_data['released'] = getIntFromRequest('version_release');
 $version_data['project_id'] = $mantisbtConf['id_mantisbt'];
-$version_data['name'] = $_POST['version_name'];
-$version_data['description'] = $_POST['version_description'];
-list($day, $month, $year) = split('[/.-]', $_POST['version_date_order']);
+$version_data['name'] = getStringFromRequest('version_name');
+$version_data['description'] = getStringFromRequest('version_description');
+list($day, $month, $year) = split('[/.-]', getStringFromRequest('version_date_order'));
 $version_data['date_order'] = $month."/".$day."/".$year;
 
 try {
     $clientSOAP = new SoapClient($mantisbtConf['url']."/api/soap/mantisconnect.php?wsdl", array('trace'=>true, 'exceptions'=>true));
     $clientSOAP->__soapCall('mc_project_version_update', array("username" => $username, "password" => $password, "version_id" => $version_id, "version" => $version_data));
-    if (isset($_POST['transverse'])) {
-        $listChild = $clientSOAP->__soapCall('mc_project_get_all_subprojects', array("username" => $username, "password" => $password, "project_id" => $idProjetMantis));
-        foreach ($listChild as $key => $child) {
-            $listVersions = $clientSOAP->__soapCall('mc_project_get_versions', array("username" => $username, "password" => $password, "project_id" => $child));
-            foreach ($listVersions as $key => $version) {
-                if ($version->name == $_POST['version_old_name'])
-                    $child_version_id = $version->id;
-            }
-            $version_data['project_id'] = $child;
-            $clientSOAP->__soapCall('mc_project_version_update', array("username" => $username, "password" => $password, "version_id" => $child_version_id, "version" => $version_data));
-        }
-    }
+// need to be implemented using projects-hierarchy plugin
+//     if (isset($_POST['transverse'])) {
+//         $listChild = $clientSOAP->__soapCall('mc_project_get_all_subprojects', array("username" => $username, "password" => $password, "project_id" => $idProjetMantis));
+//         foreach ($listChild as $key => $child) {
+//             $listVersions = $clientSOAP->__soapCall('mc_project_get_versions', array("username" => $username, "password" => $password, "project_id" => $child));
+//             foreach ($listVersions as $key => $version) {
+//                 if ($version->name == getStringFromRequest('version_old_name'))
+//                     $child_version_id = $version->id;
+//             }
+//             $version_data['project_id'] = $child;
+//             $clientSOAP->__soapCall('mc_project_version_update', array("username" => $username, "password" => $password, "version_id" => $child_version_id, "version" => $version_data));
+//         }
+//     }
 } catch (SoapFault $soapFault) {
 	$error_msg = _('Task failed')._(': ').$version_data['name'].' '.$soapFault->faultstring;
 	session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&error_msg='.urlencode($error_msg));
 }
-$feedback = _('Task succeeded');
+$feedback = _('Task succeeded.');
 session_redirect('plugins/mantisbt/?type=admin&group_id='.$group_id.'&pluginname='.$mantisbt->name.'&feedback='.urlencode($feedback));
 
 ?>

Modified: trunk/src/plugins/mantisbt/action/updateuserConf.php
===================================================================
--- trunk/src/plugins/mantisbt/action/updateuserConf.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/action/updateuserConf.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -22,13 +22,14 @@
  */
 
 global $mantisbt; // the mantisbt object
+global $user;
 
 $confArr = array();
 $confArr['mantisbt_user'] = getStringFromRequest('mantisbt_user');
 $confArr['mantisbt_password'] = getStringFromRequest('mantisbt_password');
 
 if (!$mantisbt->updateUserConf($confArr))
-	session_redirect('/plugins/mantisbt/?type=user&pluginname='.$mantisbt->name.'&error_msg='.urlencode($group->getErrorMessage()));
+	session_redirect('/plugins/mantisbt/?type=user&pluginname='.$mantisbt->name.'&error_msg='.urlencode($user->getErrorMessage()));
 
 $feedback = _('MantisBT User configuration successfully updated.');
 session_redirect('/plugins/mantisbt/?type=user&pluginname='.$mantisbt->name.'&view=adminuser&feedback='.urlencode($feedback));

Modified: trunk/src/plugins/mantisbt/common/MantisBTPlugin.class.php
===================================================================
--- trunk/src/plugins/mantisbt/common/MantisBTPlugin.class.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/common/MantisBTPlugin.class.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -4,7 +4,7 @@
  *
  * Copyright 2009, Fabien Dubois - Capgemini
  * Copyright 2009-2011, Franck Villaume - Capgemini
- * Copyright 2011, Franck Villaume - TrivialDev
+ * Copyright 2011-2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -435,23 +435,36 @@
 	 * @return	bool	success or not
 	 */
 	function initialize($group_id, $confArr) {
+		if ($confArr['globalconf']) {
+			$globalConfArr = $this->getGlobalconf();
+			$confArr['url'] = $globalConfArr['url'];
+			$confArr['soap_user'] = $globalConfArr['soap_user'];
+			$confArr['soap_password'] = $globalConfArr['soap_password'];
+		}
 		if ($confArr['mantisbtcreate']) {
 			$idProjectMantis = $this->addProjectMantis($group_id, $confArr);
+		} elseif ($confArr['mantisbtname'] && sizeof($confArr['mantisbtname'])) {
+			$idProjectMantis = $this->getProjectMantisByName($group_id, $confArr);
 		} else {
-			$idProjectMantis = $this->getProjectMantisByName($group_id, $confArr);
+			$groupObject = group_get_object($group_id);
+			$groupObject->setError('initialize::Error: '. _('MantisBT project not initialized, missing params'));
 		}
-		if ($idProjectMantis) {
-			$result = db_query_params('insert into plugin_mantisbt (id_group, id_mantisbt, url, soap_user, soap_password, sync_roles)
-							values ($1, $2, $3, $4, $5, $6)',
+
+		if (isset($idProjectMantis) && $idProjectMantis) {
+			$result = db_query_params('insert into plugin_mantisbt (id_group, id_mantisbt, url, soap_user, soap_password, sync_roles, use_global)
+							values ($1, $2, $3, $4, $5, $6, $7)',
 							array($group_id,
 								$idProjectMantis,
 								$confArr['url'],
 								$confArr['soap_user'],
 								$confArr['soap_password'],
-								$confArr['sync_roles']));
-			if (!$result)
+								$confArr['sync_roles'],
+								$confArr['globalconf']));
+			if (!$result) {
+				$groupObject = group_get_object($group_id);
+				$groupObject->setError('initialize::Error: '. db_error());
 				return false;
-
+			}
 			return true;
 		}
 		return false;
@@ -536,7 +549,7 @@
 				return $mantisbtProject->id;
 			}
 		}
-		$groupObject->setError('getProjectMantisByName::Error: mantisbt project not found');
+		$groupObject->setError('getProjectMantisByName::Error: '. _('MantisBT project not found'));
 		return false;
 	}
 

Modified: trunk/src/plugins/mantisbt/view/admin/addVersion.php
===================================================================
--- trunk/src/plugins/mantisbt/view/admin/addVersion.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/view/admin/addVersion.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -33,9 +34,10 @@
 echo $HTML->boxTop(_('Add a new version'));
 echo '<td>';
 echo '<label>'._('Name').'</label><input name="version" type="text" size="10" />';
-if ($group->usesPlugin('projects-hierarchy')) {
-	echo '<input name="transverse" type="checkbox" value="1" >'. _('Cross version (son included)') .'</input>';
-}
+// need to be implemented ....
+// if ($group->usesPlugin('projects-hierarchy')) {
+// 	echo '<input name="transverse" type="checkbox" value="1" >'. _('Cross version (son included)') .'</input>';
+// }
 echo '</td>';
 echo '</tr><tr>';
 echo '<td>';

Modified: trunk/src/plugins/mantisbt/view/admin/editVersion.php
===================================================================
--- trunk/src/plugins/mantisbt/view/admin/editVersion.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/view/admin/editVersion.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,6 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
+ * Copyright 2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -83,9 +84,10 @@
 	echo	'</tr>';
 	echo	'</tbody>';
 	echo '</table>';
-	if ($group->usesPlugin('projects-hierarchy')) {
-		echo '<input type="checkbox" name="transverse" value="1">'._('Cross version (son included)').'</input>';
-	}
+// need to be implemented
+// 	if ($group->usesPlugin('projects-hierarchy')) {
+// 		echo '<input type="checkbox" name="transverse" value="1">'._('Cross version (son included)').'</input>';
+// 	}
 	echo '<input type="hidden" name="version_id" value="'.$idVersion.'"></input>';
 	echo '<input type="hidden" name="version_old_name" value="'.$detailVersion->name.'"></input>';
 	echo '<br/>';

Modified: trunk/src/plugins/mantisbt/view/admin/viewConfiguration.php
===================================================================
--- trunk/src/plugins/mantisbt/view/admin/viewConfiguration.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/view/admin/viewConfiguration.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,7 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2011, Franck Villaume - Capgemini
- * Copyright 2011, Franck Villaume - TrivialDev
+ * Copyright 2011-2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -26,6 +26,7 @@
 global $mantisbt;
 global $mantisbtConf;
 global $use_tooltips;
+global $group_id;
 
 ?>
 <script type="text/javascript">
@@ -56,7 +57,7 @@
 echo '<tr><td><label id="mantisbtinit-global" ';
 if ($use_tooltips)
 	echo 'title="'._('Use the global configuration defined at forge level').'"';
-echo ' >'._('Use global configuration').'</label></td><td><input id="mantisbtglobalconf" type="checkbox" name="global_conf" ';
+echo ' >'._('Use global configuration').'</label></td><td><input id="mantisbtglobalconf" type="checkbox" name="global_conf" value="1" ';
 if ($mantisbtConf['use_global']) {
 	echo 'checked="checked" ';
 }

Modified: trunk/src/plugins/mantisbt/view/init.php
===================================================================
--- trunk/src/plugins/mantisbt/view/init.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/view/init.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,7 +3,7 @@
  * MantisBT plugin
  *
  * Copyright 2011, Franck Villaume - Capgemini
- * Copyright 2011, Franck Villaume - TrivialDev
+ * Copyright 2011-2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -63,7 +63,7 @@
 echo '<tr><td><label id="mantisbtinit-global" ';
 if ($use_tooltips)
 	echo 'title="'._('Use the global configuration defined at forge level').'"';
-echo ' >'._('Use global configuration').'</label></td><td><input id="mantisbtglobalconf" type="checkbox" name="global_conf" /></td></tr>';
+echo ' >'._('Use global configuration').'</label></td><td><input id="mantisbtglobalconf" type="checkbox" name="global_conf" value="1" /></td></tr>';
 echo '<tr><td><label id="mantisbtinit-url" ';
 if ($use_tooltips)
 	echo 'title="'._('Specify the Full URL of the MantisBT Web Server.').'"';
@@ -79,7 +79,7 @@
 echo '<tr><td><label id="mantisbtinit-create" ';
 if ($use_tooltips)
 	echo 'title="'._('If this project does NOT exist in MantisBT, do you want to create it ?').'"';
-echo ' >Create the project in MantisBT</label></td><td><input id="mantisbtcreate" type="checkbox" name="mantisbtcreate" value="1" ></td></tr>';
+echo ' >Create the project in MantisBT</label></td><td><input id="mantisbtcreate" type="checkbox" name="mantisbtcreate" value="1" /></td></tr>';
 echo '<tr><td><label id="mantisbtinit-name" ';
 if ($use_tooltips)
 	echo 'title="'._('Specify the name of the project in MantisBT if already created in MantisBT').'"';

Modified: trunk/src/plugins/mantisbt/www/admin/index.php
===================================================================
--- trunk/src/plugins/mantisbt/www/admin/index.php	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/www/admin/index.php	2012-04-14 12:42:03 UTC (rev 15340)
@@ -3,7 +3,7 @@
  * Admin MantisBT page
  *
  * Copyright 2010-2011, Franck Villaume - Capgemini
- * Copyright 2011, Franck Villaume - TrivialDev
+ * Copyright 2011-2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -56,8 +56,8 @@
 			echo '</td><td valign="top">';
 			include ("mantisbt/view/admin/addVersion.php");
 			echo '</td></tr></table>';
-			include ("mantisbt/view/admin/viewConfiguration.php");
 		}
+		include ("mantisbt/view/admin/viewConfiguration.php");
 		break;
 	}
 }

Modified: trunk/src/plugins/mantisbt/www/scripts/MantisBTController.js
===================================================================
--- trunk/src/plugins/mantisbt/www/scripts/MantisBTController.js	2012-04-14 11:45:13 UTC (rev 15339)
+++ trunk/src/plugins/mantisbt/www/scripts/MantisBTController.js	2012-04-14 12:42:03 UTC (rev 15340)
@@ -2,7 +2,7 @@
  * MantisBT Plugin
  *
  * Copyright 2011, Franck Villaume - Capgemini
- * Copyright 2011, Franck Villaume - TrivialDev
+ * Copyright 2011-2012, Franck Villaume - TrivialDev
  * http://fusionforge.org
  *
  * This file is part of FusionForge. FusionForge is free software;
@@ -61,12 +61,10 @@
 
 	toggleAllInput: function() {
 		if (!this.params.checkboxGlobalConf.is(":checked")) {
-			this.params.inputName.attr('disabled',false);
 			this.params.inputUrl.attr('disabled',false);
 			this.params.inputUser.attr('disabled',false);
 			this.params.inputPassword.attr('disabled',false);
 		} else {
-			this.params.inputName.attr('disabled',true);
 			this.params.inputUrl.attr('disabled',true);
 			this.params.inputUser.attr('disabled',true);
 			this.params.inputPassword.attr('disabled',true);




More information about the Fusionforge-commits mailing list