[Fusionforge-commits] FusionForge branch master updated. 64e7a234a955d4f29d7e6a91063edea685896f8d

Alain Peyrat aljeux at fusionforge.org
Tue Dec 18 09:41:30 CET 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".

The branch, master has been updated
       via  64e7a234a955d4f29d7e6a91063edea685896f8d (commit)
      from  4ce79d7f2bde313b0bf4fdded04c0d0919ca2bc2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 64e7a234a955d4f29d7e6a91063edea685896f8d
Author: Alain Peyrat <alain.peyrat at alcatel-lucent.com>
Date:   Tue Dec 18 09:41:12 2012 +0100

    Unreachable = untestable => Removed, getMessages() implementation has changed in trunk (now ajax based & persistent)

diff --git a/src/common/tracker/Artifact.class.php b/src/common/tracker/Artifact.class.php
index b6b254b..dab1f94 100644
--- a/src/common/tracker/Artifact.class.php
+++ b/src/common/tracker/Artifact.class.php
@@ -677,22 +677,11 @@ class Artifact extends Error {
 	 * @param string $order
 	 * @return resource result set.
 	 */
-	function getMessages($if_i_get_the_person_reinventing_the_wheel='up') {
-		/*
-		 * This is necessary because someone committed a change
-		 * to this method in FusionForge trunk that accepts 'up'
-		 * as default (luckily, it’s the same!) and 'down' as
-		 * alternative probability, whereas FusionForge 5.2 has
-		 * false as default and true for ascending order, so we
-		 * need to check this out and use === to be sure ☹
-		 */
-		if ($if_i_get_the_person_reinventing_the_wheel === 'up') {
-			$order = 'DESC';
-		} elseif ($if_i_get_the_person_reinventing_the_wheel === true) {
-			$order = 'ASC';
-		} elseif ($if_i_get_the_person_reinventing_the_wheel === false) {
+	function getMessages($order='up') {
+		if ($order == 'up') {
 			$order = 'DESC';
-		} else {
+		}
+		else {
 			$order = 'ASC';
 		}
 		return db_query_params('SELECT * FROM artifact_message_user_vw WHERE artifact_id=$1 ORDER BY adddate ' . $order . ', id ASC',

-----------------------------------------------------------------------

Summary of changes:
 src/common/tracker/Artifact.class.php |   19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
FusionForge



More information about the Fusionforge-commits mailing list