[Fusionforge-commits] r18394 - in trunk/src/www: my pm themes/funky themes/gforge

Marc-Etienne VARGENAU vargenau at fusionforge.org
Tue Nov 5 20:37:29 CET 2013


Author: vargenau
Date: 2013-11-05 20:37:29 +0100 (Tue, 05 Nov 2013)
New Revision: 18394

Modified:
   trunk/src/www/my/dashboard.php
   trunk/src/www/pm/browse_task.php
   trunk/src/www/pm/detail_task.php
   trunk/src/www/pm/mod_task.php
   trunk/src/www/themes/funky/Theme.class.php
   trunk/src/www/themes/gforge/Theme.class.php
Log:
Do not use void function result

Modified: trunk/src/www/my/dashboard.php
===================================================================
--- trunk/src/www/my/dashboard.php	2013-11-05 19:36:43 UTC (rev 18393)
+++ trunk/src/www/my/dashboard.php	2013-11-05 19:37:29 UTC (rev 18394)
@@ -187,10 +187,10 @@
 	<!--  Bottom Row   -->
 <!--
 	<tr><td colspan="2">';
-	echo show_priority_colors_key();
+	show_priority_colors_key();
 	echo '
 	</td></tr>
 -->
 	</table>';
-	echo site_user_footer(array());
+	site_user_footer(array());
 }

Modified: trunk/src/www/pm/browse_task.php
===================================================================
--- trunk/src/www/pm/browse_task.php	2013-11-05 19:36:43 UTC (rev 18393)
+++ trunk/src/www/pm/browse_task.php	2013-11-05 19:37:29 UTC (rev 18394)
@@ -370,7 +370,7 @@
 				_('No Change')) .'</td>
 			<td><strong>'._('Priority').
 				'</strong><br />';
-			echo build_priority_select_box ('priority', '100', true);
+			build_priority_select_box ('priority', '100', true);
 			echo '</td>
 			</tr>
 

Modified: trunk/src/www/pm/detail_task.php
===================================================================
--- trunk/src/www/pm/detail_task.php	2013-11-05 19:36:43 UTC (rev 18393)
+++ trunk/src/www/pm/detail_task.php	2013-11-05 19:37:29 UTC (rev 18394)
@@ -159,19 +159,19 @@
 
 	<tr>
 		<td colspan="2">
-			<?php echo $pt->showDependentTasks(); ?>
+			<?php $pt->showDependentTasks(); ?>
 		</td>
 	</tr>
 
 	<tr>
 		<td colspan="2">
-			<?php echo $pt->showRelatedArtifacts(); ?>
+			<?php $pt->showRelatedArtifacts(); ?>
 		</td>
 	</tr>
 
 	<tr>
 		<td colspan="2">
-			<?php echo $pt->showMessages($sort_comments_chronologically, "/pm/task.php?func=detailtask&project_task_id=$project_task_id&group_id=$group_id&group_project_id=$group_project_id"); ?>
+			<?php $pt->showMessages($sort_comments_chronologically, "/pm/task.php?func=detailtask&project_task_id=$project_task_id&group_id=$group_id&group_project_id=$group_project_id"); ?>
 		</td>
 	</tr>
 	<?php
@@ -181,7 +181,7 @@
 	?>
 	<tr>
 		<td colspan="2">
-			<?php echo $pt->showHistory(); ?>
+			<?php $pt->showHistory(); ?>
 		</td>
 	</tr>
 

Modified: trunk/src/www/pm/mod_task.php
===================================================================
--- trunk/src/www/pm/mod_task.php	2013-11-05 19:36:43 UTC (rev 18393)
+++ trunk/src/www/pm/mod_task.php	2013-11-05 19:37:29 UTC (rev 18394)
@@ -145,11 +145,11 @@
 		<td colspan="3">
 		<strong><?php echo _('Start Date') ?>:</strong><br />
 		<?php
-		echo $pg->showMonthBox ('start_month',date('m', $pt->getStartDate()));
-		echo $pg->showDayBox ('start_day',date('d', $pt->getStartDate()));
-		echo $pg->showYearBox ('start_year',date('Y', $pt->getStartDate()));
-		echo $pg->showHourBox ('start_hour',date('G', $pt->getStartDate()));
-		echo $pg->showMinuteBox ('start_minute',date('i',$pt->getStartDate()));
+		$pg->showMonthBox ('start_month',date('m', $pt->getStartDate()));
+		$pg->showDayBox ('start_day',date('d', $pt->getStartDate()));
+		$pg->showYearBox ('start_year',date('Y', $pt->getStartDate()));
+		$pg->showHourBox ('start_hour',date('G', $pt->getStartDate()));
+		$pg->showMinuteBox ('start_minute',date('i',$pt->getStartDate()));
 		?><br /><?php echo _('The system will modify your start/end dates if you attempt to create a start date earlier than the end date of any tasks you depend on.') ?>
 		<br /><a href="calendar.php?group_id=<?php echo $group_id; ?>&group_project_id=<?php echo $group_project_id; ?>" target="_blank"><?php echo _('View Calendar') ?></a>
 		</td>
@@ -159,11 +159,11 @@
 		<td colspan="3">
 		<strong><?php echo _('End Date') ?>:</strong><br />
 		<?php
-		echo $pg->showMonthBox ('end_month',date('m', $pt->getEndDate()));
-		echo $pg->showDayBox ('end_day',date('d', $pt->getEndDate()));
-		echo $pg->showYearBox ('end_year',date('Y', $pt->getEndDate()));
-		echo $pg->showHourBox ('end_hour',date('G', $pt->getEndDate()));
-		echo $pg->showMinuteBox ('end_minute',date('i', $pt->getEndDate()));
+		$pg->showMonthBox ('end_month',date('m', $pt->getEndDate()));
+		$pg->showDayBox ('end_day',date('d', $pt->getEndDate()));
+		$pg->showYearBox ('end_year',date('Y', $pt->getEndDate()));
+		$pg->showHourBox ('end_hour',date('G', $pt->getEndDate()));
+		$pg->showMinuteBox ('end_minute',date('i', $pt->getEndDate()));
 		?>
 		</td>
 	</tr>
@@ -223,19 +223,19 @@
 -->
 	<tr>
 		<td colspan="3">
-			<?php echo $pt->showDependentTasks(); ?>
+			<?php $pt->showDependentTasks(); ?>
 		</td>
 	</tr>
 
 	<tr>
 		<td colspan="3">
-			<?php echo $pt->showRelatedArtifacts(); ?>
+			<?php $pt->showRelatedArtifacts(); ?>
 		</td>
 	</tr>
 
 	<tr>
 		<td colspan="3">
-			<?php echo $pt->showMessages($sort_comments_chronologically, "/pm/task.php?func=detailtask&project_task_id=$project_task_id&group_id=$group_id&group_project_id=$group_project_id"); ?>
+			<?php $pt->showMessages($sort_comments_chronologically, "/pm/task.php?func=detailtask&project_task_id=$project_task_id&group_id=$group_id&group_project_id=$group_project_id"); ?>
 		</td>
 	</tr>
 	<?php
@@ -245,7 +245,7 @@
 	?>
 	<tr>
 		<td colspan="3">
-			<?php echo $pt->showHistory(); ?>
+			<?php $pt->showHistory(); ?>
 		</td>
 	</tr>
 

Modified: trunk/src/www/themes/funky/Theme.class.php
===================================================================
--- trunk/src/www/themes/funky/Theme.class.php	2013-11-05 19:36:43 UTC (rev 18393)
+++ trunk/src/www/themes/funky/Theme.class.php	2013-11-05 19:37:29 UTC (rev 18394)
@@ -101,7 +101,7 @@
 		echo '<!-- inner tabs -->' . "\n";
 		echo '<div class="innertabs">' . "\n";
 		if (isset($params['group']) && $params['group']) {
-			echo $this->projectTabs($params['toptab'], $params['group']);
+			$this->projectTabs($params['toptab'], $params['group']);
 		}
 
 		echo '</div>' . "\n";

Modified: trunk/src/www/themes/gforge/Theme.class.php
===================================================================
--- trunk/src/www/themes/gforge/Theme.class.php	2013-11-05 19:36:43 UTC (rev 18393)
+++ trunk/src/www/themes/gforge/Theme.class.php	2013-11-05 19:37:29 UTC (rev 18394)
@@ -95,10 +95,10 @@
 
 			<!-- outer tabs -->
 			';
-                echo $this->outerTabs($params);
+                $this->outerTabs($params);
 				echo '<!-- inner tabs -->' . "\n";
 		if (isset($params['group']) && $params['group']) {
-			echo $this->projectTabs($params['toptab'],$params['group']);
+			$this->projectTabs($params['toptab'],$params['group']);
 		}
 		echo '<div id="maindiv">
 ';




More information about the Fusionforge-commits mailing list