[Fusionforge-commits] FusionForge branch master updated. a2921e32e2883c5dffbfd8425894c3f7521b9a02

Franck VILLAUME nerville at fusionforge.org
Fri Jan 10 15:19:35 CET 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".

The branch, master has been updated
       via  a2921e32e2883c5dffbfd8425894c3f7521b9a02 (commit)
       via  3eb8e9d73fd02d9c777e5e9d9eb85c3ed1de5a03 (commit)
      from  baf49df59b123a4ee0c33fc1dfc79be7140648a7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a2921e32e2883c5dffbfd8425894c3f7521b9a02
Author: Franck Villaume <franck.villaume at trivialdev.com>
Date:   Fri Jan 10 15:18:58 2014 +0100

    fix [#619]: unable to rename a query.

diff --git a/src/common/tracker/ArtifactQuery.class.php b/src/common/tracker/ArtifactQuery.class.php
index 372c942..652a210 100644
--- a/src/common/tracker/ArtifactQuery.class.php
+++ b/src/common/tracker/ArtifactQuery.class.php
@@ -742,10 +742,6 @@ class ArtifactQuery extends Error {
 			$this->setError(_('Must Be Logged In'));
 			return false;
 		}
-		if (!$this->Exist(htmlspecialchars($name))) {
-			$this->setError(_('Query does not exist'));
-			return false;
-		}
 		if ($query_type>0 && !forge_check_perm ('tracker', $this->ArtifactType->getID(), 'manager')) {
 			$this->setError(_('You must have tracker admin rights to set or update a project level query.'));
 			return false;

commit 3eb8e9d73fd02d9c777e5e9d9eb85c3ed1de5a03
Author: Franck Villaume <franck.villaume at trivialdev.com>
Date:   Fri Jan 10 15:08:45 2014 +0100

    tracker: phpdoc

diff --git a/src/common/tracker/ArtifactQuery.class.php b/src/common/tracker/ArtifactQuery.class.php
index 1f0adfa..372c942 100644
--- a/src/common/tracker/ArtifactQuery.class.php
+++ b/src/common/tracker/ArtifactQuery.class.php
@@ -118,7 +118,7 @@ class ArtifactQuery extends Error {
 	 * create - create a row in the table that stores a saved query for
 	 * a tracker.
 	 *
-	 * @param	$name
+	 * @param	string		$name
 	 * @param	$status
 	 * @param	$assignee
 	 * @param	$moddaterange
@@ -127,8 +127,8 @@ class ArtifactQuery extends Error {
 	 * @param	$extra_fields
 	 * @param	int		$opendaterange
 	 * @param	int		$closedaterange
-	 * @param	$summary
-	 * @param	$description
+	 * @param	string		$summary
+	 * @param	string		$description
 	 * @param	$followups
 	 * @param	int		$query_type
 	 * @param	array		$query_options
@@ -208,7 +208,7 @@ class ArtifactQuery extends Error {
 	/**
 	 * fetchData - re-fetch the data for this ArtifactQuery from the database.
 	 *
-	 * @param	int	$id ID of saved query.
+	 * @param	int	$id	ID of saved query.
 	 * @return	boolean	success.
 	 */
 	function fetchData($id) {
@@ -246,8 +246,22 @@ class ArtifactQuery extends Error {
 	}
 
 	/**
+	 * insertElements - ???
 	 *
-	 *
+	 * @param	int		$id
+	 * @param	$status
+	 * @param	$submitter
+	 * @param	$assignee
+	 * @param	$moddaterange
+	 * @param	$sort_col
+	 * @param	$sort_ord
+	 * @param	$extra_fields
+	 * @param	$opendaterange
+	 * @param	$closedaterange
+	 * @param	string		$summary
+	 * @param	string		$description
+	 * @param	$followups
+	 * @return	boolean		True/false on success or not.
 	 */
 	function insertElements($id,$status,$submitter,$assignee,$moddaterange,$sort_col,$sort_ord,$extra_fields,$opendaterange,$closedaterange,$summary,$description,$followups) {
 		$res = db_query_params ('DELETE FROM artifact_query_fields WHERE artifact_query_id=$1',
@@ -711,11 +725,11 @@ class ArtifactQuery extends Error {
 	 * @param	string		$opendaterange
 	 * @param	string		$closedaterange
 	 * @param	$summary
-	 * @param	 $description
+	 * @param	$description
 	 * @param	$followups
 	 * @param	int		$query_type	Id of the saved query
 	 * @param	array		$query_options
-	 * @param	string	$submitter
+	 * @param	string		$submitter
 	 * @return	bool		success.
 	 */
 	function update($name,$status,$assignee,$moddaterange,$sort_col,$sort_ord,$extra_fields,$opendaterange='',$closedaterange='',

-----------------------------------------------------------------------

Summary of changes:
 src/common/tracker/ArtifactQuery.class.php |   32 ++++++++++++++++++----------
 1 file changed, 21 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
FusionForge



More information about the Fusionforge-commits mailing list