[Fusionforge-commits] FusionForge branch master updated. 6.0.4-639-gebf4d25

Marc-Etienne VARGENAU vargenau at libremir.placard.fr.eu.org
Mon Jul 4 13:40:03 CEST 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".

The branch, master has been updated
       via  ebf4d252c8a5a4ea09b9160ad2e64ce67931144b (commit)
       via  f8a01f549962c93b3ef9758bb9bf1d91212b2bb3 (commit)
      from  a0f887770952cd42e74becd71c20eb2ac4e5f5d3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=ebf4d252c8a5a4ea09b9160ad2e64ce67931144b

commit ebf4d252c8a5a4ea09b9160ad2e64ce67931144b
Author: Marc-Etienne Vargenau <Marc-Etienne.Vargenau at alcatel-lucent.com>
Date:   Mon Jul 4 13:39:57 2016 +0200

    Remove & in function definition

diff --git a/src/www/soap/common/group.php b/src/www/soap/common/group.php
index a51f149..4156ba0 100644
--- a/src/www/soap/common/group.php
+++ b/src/www/soap/common/group.php
@@ -327,7 +327,7 @@ $server->register(
 	$uri.'#deleteGroupRole','rpc','encoded'
 );
 
-function &getGroups($session_ser,$group_ids) {
+function getGroups($session_ser,$group_ids) {
 	global $feedback;
 	continue_session($session_ser);
 
@@ -344,7 +344,7 @@ function &getGroups($session_ser,$group_ids) {
 	return groups_to_soap($grps);
 }
 
-function &getGroupsByName($session_ser,$group_names) {
+function getGroupsByName($session_ser,$group_names) {
 	session_continue($session_ser);
 	$grps = group_get_objects_by_name($group_names);
 	if (!$grps) {
@@ -355,7 +355,7 @@ function &getGroupsByName($session_ser,$group_names) {
 }
 
 // use as a way to get group names for use in getGroupsByName
-function &getPublicProjectNames($session_ser) {
+function getPublicProjectNames($session_ser) {
 	continue_session($session_ser);
 	$forge = new FusionForge();
 	$result = $forge->getPublicProjectNames();
@@ -535,7 +535,7 @@ function removeUserFromGroup ($session_ser,$user_id, $role_id){
 }
 
 //[Yosu] getGroupRoles (session_ser, group_id)
-function &getGroupRoles($session_ser,$group_id) {
+function getGroupRoles($session_ser,$group_id) {
 	continue_session($session_ser);
 
 	$group = group_get_object($group_id);
@@ -691,7 +691,7 @@ function deleteGroupRole ($session_ser, $group_id, $role_id){
 /*
 	Converts an array of Group objects to soap data
 */
-function &groups_to_soap($grps) {
+function groups_to_soap($grps) {
 	$return = array();
 	$ra = RoleAnonymous::getInstance() ;
 
@@ -740,7 +740,7 @@ function &groups_to_soap($grps) {
 /*
 	[Yosu]	Converts an array of Role objects to soap data
 */
-function &roles_to_soap($roles, $group_id) {
+function roles_to_soap($roles, $group_id) {
 	$return = array();
 
 	for ($i=0; $i<count($roles); $i++) {
diff --git a/src/www/soap/common/user.php b/src/www/soap/common/user.php
index 8308213..dd7f008 100644
--- a/src/www/soap/common/user.php
+++ b/src/www/soap/common/user.php
@@ -185,7 +185,7 @@ $server->register(
 );
 
 //get user objects for array of user_ids
-function &getUsers($session_ser,$user_ids) {
+function getUsers($session_ser,$user_ids) {
 	continue_session($session_ser);
 	$users = user_get_objects($user_ids);
 	if (!$users) {
@@ -320,7 +320,7 @@ function changePassword ($session_ser,$user_id,$password){
 }
 
 //get groups for user_id
-function &userGetGroups($session_ser,$user_id) {
+function userGetGroups($session_ser,$user_id) {
 	continue_session($session_ser);
 	$user = user_get_object($user_id);
 	if (!$user) {
@@ -332,7 +332,7 @@ function &userGetGroups($session_ser,$user_id) {
 /*
 	Converts an array of User objects to soap data
 */
-function &users_to_soap($users) {
+function users_to_soap($users) {
 	$return = array();
 	for ($i=0; $i<count($users); $i++) {
 		if ($users[$i]->isError()) {
diff --git a/src/www/soap/docman/docman.php b/src/www/soap/docman/docman.php
index 0969e16..42932e0 100644
--- a/src/www/soap/docman/docman.php
+++ b/src/www/soap/docman/docman.php
@@ -164,7 +164,7 @@ $server->register(
 //
 //getDocumentStates
 //
-function &getDocumentStates($session_ser) {
+function getDocumentStates($session_ser) {
 	continue_session($session_ser);
 	$return = array();
 
@@ -212,7 +212,7 @@ $server->register(
 	$uri,$uri.'#addDocument','rpc','encoded'
 );
 
-function &addDocument($session_ser,$group_id,$doc_group,$title,$description,$base64_contents,$filename,$file_url) {
+function addDocument($session_ser,$group_id,$doc_group,$title,$description,$base64_contents,$filename,$file_url) {
 	continue_session($session_ser);
 
 	$g = group_get_object($group_id);
@@ -270,7 +270,7 @@ $server->register(
 //
 //updateDocument
 //
-function &updateDocument($session_ser,$group_id,$doc_group,$doc_id,$title,$description, $base64_contents,$filename,$file_url,$state_id) {
+function updateDocument($session_ser,$group_id,$doc_group,$doc_id,$title,$description, $base64_contents,$filename,$file_url,$state_id) {
 	continue_session($session_ser);
 
 	$g = group_get_object($group_id);
@@ -352,7 +352,7 @@ $server->register(
 //
 // addDocumentGroup
 //
-function &addDocumentGroup($session_ser,$group_id,$groupname,$parent_doc_group) {
+function addDocumentGroup($session_ser,$group_id,$groupname,$parent_doc_group) {
 	continue_session($session_ser);
 
 	$g = group_get_object($group_id);
@@ -394,7 +394,7 @@ $server->register(
 //
 // updateDocumentGroup
 //
-function &updateDocumentGroup($session_ser, $group_id, $doc_group, $new_groupname, $new_parent_doc_group) {
+function updateDocumentGroup($session_ser, $group_id, $doc_group, $new_groupname, $new_parent_doc_group) {
 	continue_session($session_ser);
 
 	$g = group_get_object($group_id);
@@ -435,7 +435,7 @@ $server->register(
 //	getDocuments
 //
 
-function &getDocuments($session_ser,$group_id,$doc_group_id) {
+function getDocuments($session_ser,$group_id,$doc_group_id) {
 	continue_session($session_ser);
 	$g = group_get_object($group_id);
 	if (!$g || !is_object($g)) {
@@ -500,7 +500,7 @@ $server->register(
 //
 //getDocumentGroups
 //
-function &getDocumentGroups($session_ser,$group_id) {
+function getDocumentGroups($session_ser,$group_id) {
 	continue_session($session_ser);
 	$g = group_get_object($group_id);
 	if (!$g || !is_object($g)) {
@@ -556,7 +556,7 @@ $server->register(
 //
 //getDocumentGroup
 //
-function &getDocumentGroup($session_ser,$group_id,$doc_group) {
+function getDocumentGroup($session_ser,$group_id,$doc_group) {
 	continue_session($session_ser);
 	$g = group_get_object($group_id);
 	if (!$g || !is_object($g)) {
@@ -596,7 +596,7 @@ $server->register(
 ///
 /// getDocumentFiles
 ///
-function &getDocumentFiles($session_ser,$group_id,$doc_id) {
+function getDocumentFiles($session_ser,$group_id,$doc_id) {
 	continue_session($session_ser);
 	$g = group_get_object($group_id);
 	if (!$g || !is_object($g)) {
diff --git a/src/www/soap/pm/pm.php b/src/www/soap/pm/pm.php
index bf6b2cd..6a40e87 100644
--- a/src/www/soap/pm/pm.php
+++ b/src/www/soap/pm/pm.php
@@ -365,7 +365,7 @@ $server->register(
 //
 //	getProjectGroups
 //
-function &getProjectGroups($session_ser,$group_id) {
+function getProjectGroups($session_ser,$group_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -408,7 +408,7 @@ function projectgroups_to_soap($pg_arr) {
 //
 //	addProjectTask
 //
-function &addProjectTask($session_ser,$group_id,$group_project_id,$summary,$details,$priority,
+function addProjectTask($session_ser,$group_id,$group_project_id,$summary,$details,$priority,
 	$hours,$start_date,$end_date,$category_id,$percent_complete,$assigned_arr,$depend_arr,$duration,$parent_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
@@ -449,7 +449,7 @@ function &addProjectTask($session_ser,$group_id,$group_project_id,$summary,$deta
 //
 //  Update ProjectTask
 //
-function &updateProjectTask($session_ser,$group_id,$group_project_id,$project_task_id,
+function updateProjectTask($session_ser,$group_id,$group_project_id,$project_task_id,
 	$summary,$details,$priority,$hours,$start_date,$end_date,$status_id,$category_id,
     $percent_complete,$assigned_arr,$depend_arr,$new_group_project_id,$duration,$parent_id) {
     continue_session($session_ser);
@@ -491,7 +491,7 @@ function &updateProjectTask($session_ser,$group_id,$group_project_id,$project_ta
 //
 //	getProjectTaskCategories
 //
-function &getProjectTaskCategories($session_ser,$group_id,$group_project_id) {
+function getProjectTaskCategories($session_ser,$group_id,$group_project_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -533,7 +533,7 @@ function projectcategories_to_soap($cat_arr) {
 //
 //	getProjectTechnicians
 //
-function &getProjectTechnicians($session_ser,$group_id,$group_project_id) {
+function getProjectTechnicians($session_ser,$group_id,$group_project_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -555,7 +555,7 @@ function &getProjectTechnicians($session_ser,$group_id,$group_project_id) {
 	return users_to_soap($techs);
 }
 
-function &getProjectTasks($session_ser,$group_id,$group_project_id,$assigned_to,$status,$category,$group) {
+function getProjectTasks($session_ser,$group_id,$group_project_id,$assigned_to,$status,$category,$group) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -639,7 +639,7 @@ function projecttasks_to_soap($pt_arr) {
 //
 //	getProjectMessages
 //
-function &getProjectMessages($session_ser,$group_id,$group_project_id,$project_task_id) {
+function getProjectMessages($session_ser,$group_id,$group_project_id,$project_task_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -687,7 +687,7 @@ function projectmessages_to_soap($at_arr) {
 //
 //	addProjectMessage
 //
-function &addProjectMessage($session_ser,$group_id,$group_project_id,$project_task_id,$body) {
+function addProjectMessage($session_ser,$group_id,$group_project_id,$project_task_id,$body) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
diff --git a/src/www/soap/reporting/timeentry.php b/src/www/soap/reporting/timeentry.php
index c38b408..92d0141 100644
--- a/src/www/soap/reporting/timeentry.php
+++ b/src/www/soap/reporting/timeentry.php
@@ -43,7 +43,7 @@ $server->register(
 //      addArtifact
 //
 
-function &addTimeEntry($session_ser, $projectTaskId, $week, $daysAdjust, $timeCode, $hours)
+function addTimeEntry($session_ser, $projectTaskId, $week, $daysAdjust, $timeCode, $hours)
 {
         continue_session($session_ser);
 
diff --git a/src/www/soap/tracker/tracker.php b/src/www/soap/tracker/tracker.php
index a814f19..bbd7738 100644
--- a/src/www/soap/tracker/tracker.php
+++ b/src/www/soap/tracker/tracker.php
@@ -488,7 +488,7 @@ function artifactTypeIsMonitoring($session_ser,$group_id,$group_artifact_id) {
 //
 //	getArtifactTypes
 //
-function &getArtifactTypes($session_ser,$group_id) {
+function getArtifactTypes($session_ser,$group_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -595,7 +595,7 @@ function arrangeExtraFields($extra_fields, $extra_field_info) {
 //	addArtifact
 //
 
-function &addArtifact($session_ser,$group_id,$group_artifact_id,$status_id,
+function addArtifact($session_ser,$group_id,$group_artifact_id,$status_id,
 	$priority,$assigned_to,$summary,$details,$extra_fields) {
 
 	continue_session($session_ser);
@@ -632,7 +632,7 @@ function &addArtifact($session_ser,$group_id,$group_artifact_id,$status_id,
 //
 //	Update Artifact
 //
-function &updateArtifact($session_ser,$group_id,$group_artifact_id,$artifact_id,$status_id,
+function updateArtifact($session_ser,$group_id,$group_artifact_id,$artifact_id,$status_id,
 	$priority,$assigned_to,$summary,$details,$new_artifact_type_id,$extra_fields_data) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
@@ -670,7 +670,7 @@ function &updateArtifact($session_ser,$group_id,$group_artifact_id,$artifact_id,
 //
 //	getArtifactTechnicians
 //
-function &getArtifactTechnicians($session_ser,$group_id,$group_artifact_id) {
+function getArtifactTechnicians($session_ser,$group_id,$group_artifact_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -695,7 +695,7 @@ function &getArtifactTechnicians($session_ser,$group_id,$group_artifact_id) {
 //
 //	getArtifacts
 //
-function &getArtifacts($session_ser,$group_id,$group_artifact_id,$assigned_to,$status) {
+function getArtifacts($session_ser,$group_id,$group_artifact_id,$assigned_to,$status) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -802,7 +802,7 @@ function artifacts_to_soap($at_arr) {
 //
 //	getArtifactFiles
 //
-function &getArtifactFiles($session_ser,$group_id,$group_artifact_id,$artifact_id) {
+function getArtifactFiles($session_ser,$group_id,$group_artifact_id,$artifact_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -952,7 +952,7 @@ function addArtifactFile($session_ser,$group_id,$group_artifact_id,$artifact_id,
 //
 //	getArtifactMessages
 //
-function &getArtifactMessages($session_ser,$group_id,$group_artifact_id,$artifact_id) {
+function getArtifactMessages($session_ser,$group_id,$group_artifact_id,$artifact_id) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {
@@ -1002,7 +1002,7 @@ function artifactmessages_to_soap($at_arr) {
 //
 //	addArtifactMessage
 //
-function &addArtifactMessage($session_ser,$group_id,$group_artifact_id,$artifact_id,$body) {
+function addArtifactMessage($session_ser,$group_id,$group_artifact_id,$artifact_id,$body) {
 	continue_session($session_ser);
 	$grp = group_get_object($group_id);
 	if (!$grp || !is_object($grp)) {

https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=f8a01f549962c93b3ef9758bb9bf1d91212b2bb3

commit f8a01f549962c93b3ef9758bb9bf1d91212b2bb3
Author: Marc-Etienne Vargenau <Marc-Etienne.Vargenau at alcatel-lucent.com>
Date:   Mon Jul 4 13:38:59 2016 +0200

    Whitespace

diff --git a/src/www/news/news_utils.php b/src/www/news/news_utils.php
index a86271d..ff2aeea 100644
--- a/src/www/news/news_utils.php
+++ b/src/www/news/news_utils.php
@@ -30,8 +30,8 @@ function news_header($params) {
 		exit_disabled();
 	}
 
-	$params['toptab']='news';
-	$params['group']=$group_id;
+	$params['toptab'] = 'news';
+	$params['group'] = $group_id;
 
 	if ($group_id && ($group_id != forge_get_config('news_group'))) {
 		$menu_texts=array();
diff --git a/src/www/pm/include/ProjectGroupHTML.class.php b/src/www/pm/include/ProjectGroupHTML.class.php
index aab7502..1588a96 100644
--- a/src/www/pm/include/ProjectGroupHTML.class.php
+++ b/src/www/pm/include/ProjectGroupHTML.class.php
@@ -122,7 +122,7 @@ function pm_footer($params = array()) {
 class ProjectGroupHTML extends ProjectGroup {
 
 	function __construct(&$Group, $group_project_id=false, $arr=false) {
-		parent::__construct($Group,$group_project_id,$arr);
+		parent::__construct($Group, $group_project_id, $arr);
 	}
 
 	function statusBox($name='status_id',$checked='xyxy',$show_100=true,$text_100='None') {

-----------------------------------------------------------------------

Summary of changes:
 src/www/news/news_utils.php                   |  4 ++--
 src/www/pm/include/ProjectGroupHTML.class.php |  2 +-
 src/www/soap/common/group.php                 | 12 ++++++------
 src/www/soap/common/user.php                  |  6 +++---
 src/www/soap/docman/docman.php                | 18 +++++++++---------
 src/www/soap/pm/pm.php                        | 16 ++++++++--------
 src/www/soap/reporting/timeentry.php          |  2 +-
 src/www/soap/tracker/tracker.php              | 16 ++++++++--------
 8 files changed, 38 insertions(+), 38 deletions(-)


hooks/post-receive
-- 
FusionForge



More information about the Fusionforge-commits mailing list