[Fusionforge-commits] FusionForge branch master updated. v6.0.5-1705-g1889433
Marc-Etienne VARGENAU
vargenau at libremir.placard.fr.eu.org
Wed Apr 26 15:09:02 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".
The branch, master has been updated
via 1889433417a533e5f191f22f45a792a582eea66f (commit)
via e822c57b2d0fd4173552357c15ce2eff80772db3 (commit)
from 3c748e67a9c78c15404f418e53de00a007d5f98e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=1889433417a533e5f191f22f45a792a582eea66f
commit 1889433417a533e5f191f22f45a792a582eea66f
Author: Marc-Etienne Vargenau <marc-etienne.vargenau at nokia.com>
Date: Wed Apr 26 15:08:58 2017 +0200
Remove unused variables
diff --git a/src/common/widget/WidgetLayoutManager.class.php b/src/common/widget/WidgetLayoutManager.class.php
index 9bc6600..1c05225 100644
--- a/src/common/widget/WidgetLayoutManager.class.php
+++ b/src/common/widget/WidgetLayoutManager.class.php
@@ -664,7 +664,6 @@ class WidgetLayoutManager {
}
echo html_ac(html_ap() - 1);
foreach($categs as $c => $ws) {
- $i = 0;
$widget_rows = array();
// display widgets of the category
foreach($ws as $widget_name => $widget) {
@@ -787,7 +786,7 @@ class WidgetLayoutManager {
AND owner_id = $4
AND name = $5
AND layout_id = $6";
- $res = db_query_params($sql,array($column_id,$rank,$owner_type, $owner_id,$name, $layout_id));
+ db_query_params($sql,array($column_id,$rank,$owner_type, $owner_id,$name, $layout_id));
echo db_error();
} else {
//Insert
@@ -935,7 +934,7 @@ class WidgetLayoutManager {
WHERE owner_type = $1
AND owner_id = $2
AND column_id = $3". $_and;
- $res = db_query_params($sql,array($owner_type, $owner_id, $column_id));
+ db_query_params($sql,array($owner_type, $owner_id, $column_id));
echo db_error();
}
@@ -958,7 +957,7 @@ class WidgetLayoutManager {
WHERE owner_type = $2
AND owner_id = $3' . $_and ."
AND layout_id = $4";
- $res = db_query_params($sql,array($column_id,$owner_type,$owner_id,$layout_id));
+ db_query_params($sql,array($column_id,$owner_type,$owner_id,$layout_id));
echo db_error();
}
diff --git a/src/common/widget/Widget_MyAdmin.class.php b/src/common/widget/Widget_MyAdmin.class.php
index 08f6199..18e6dcb 100644
--- a/src/common/widget/Widget_MyAdmin.class.php
+++ b/src/common/widget/Widget_MyAdmin.class.php
@@ -102,7 +102,6 @@ class Widget_MyAdmin extends Widget {
}
function _get_admin_row($i, $text, $value, $bgcolor, $textcolor = 'white') {
global $HTML;
- $i=$i++;
$cells = array();
$cells[][] = $text;
$cells[] = array($value, 'style' => 'white-space:nowrap; width:20%; background:'. $bgcolor .'; color:'. $textcolor .'; padding: 2px 8px; font-weight:bold; text-align:center;');
diff --git a/src/common/widget/Widget_ProjectLatestDocuments.class.php b/src/common/widget/Widget_ProjectLatestDocuments.class.php
index c04ab84..a940790 100644
--- a/src/common/widget/Widget_ProjectLatestDocuments.class.php
+++ b/src/common/widget/Widget_ProjectLatestDocuments.class.php
@@ -70,7 +70,6 @@ class Widget_ProjectLatestDocuments extends Widget {
$df->getDocuments();
$keys = array_keys($df->Documents);
- $j = 0;
if (!count($keys)) {
$result .= $HTML->information(_('This project has not published any documents.'));
} else {
diff --git a/src/common/widget/Widget_Rss.class.php b/src/common/widget/Widget_Rss.class.php
index 6710eb9..2c19c81 100644
--- a/src/common/widget/Widget_Rss.class.php
+++ b/src/common/widget/Widget_Rss.class.php
@@ -63,7 +63,6 @@ require_once 'Widget.class.php';
$items = array_slice($rss->get_items(), 0, $max_items);
if (count($items)) {
$content .= $HTML->listTableTop();
- $i = 0;
foreach($items as $key => $item){
$content .= '<tr><td style="width:99%">';
if ($image = $item->get_link(0, 'image')) {
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=e822c57b2d0fd4173552357c15ce2eff80772db3
commit e822c57b2d0fd4173552357c15ce2eff80772db3
Author: Marc-Etienne Vargenau <marc-etienne.vargenau at nokia.com>
Date: Wed Apr 26 15:05:44 2017 +0200
display: hidden --> display: none; close <div>; remove unused variables
diff --git a/src/common/widget/Widget_TrackerContent.class.php b/src/common/widget/Widget_TrackerContent.class.php
index 0e86223..7ca4ead 100644
--- a/src/common/widget/Widget_TrackerContent.class.php
+++ b/src/common/widget/Widget_TrackerContent.class.php
@@ -123,7 +123,7 @@ class Widget_TrackerContent extends Widget {
$extrafieldObject = new ArtifactExtraField($ath, $keys[0]);
$divEF = html_e('div', array('id' => 'ef'.$keys[0], 'class' => 'wb_extrafield', 'style' => 'background: #e6e6e6 none repeat scroll 0 0; padding: 2px; text-align: center;'), $extrafieldObject->getName().'<div id="xef'.$keys[0].'" class="ef-widget-remove">x</div>');
} else {
- $divEF = '<div id="fake" class="wb_extrafield" style="display: hidden" />';
+ $divEF = '<div id="fake" class="wb_extrafield" style="display: none"></div>';
}
$content .= '<td class="layout-manager-column" width="'.$extrafieldID[$keys[0]][0].'%">
@@ -150,7 +150,7 @@ class Widget_TrackerContent extends Widget {
<input type="text" value="" size="20" maxsize="20" /><br />
<input type="number" value="50" autocomplete="off" size="1" maxlength="3" />%
</div>
- <div id="fake" class="wb_extrafield" style="display: hidden" />
+ <div id="fake" class="wb_extrafield" style="display: none"></div>
</td>
<td class="layout-manager-column-add">+</td>';
$content .= '<td class="layout-manager-column">
@@ -160,7 +160,7 @@ class Widget_TrackerContent extends Widget {
<input type="text" value="" size="20" maxsize="20" /><br />
<input type="number" value="50" autocomplete="off" size="1" maxlength="3" />%
</div>
- <div id="fake" class="wb_extrafield" style="display: hidden" />
+ <div id="fake" class="wb_extrafield" style="display: none"></div>
</td>
<td class="layout-manager-column-add">+</td>
</tr></table>';
@@ -362,7 +362,6 @@ EOS;
if (count($layoutExtraFieldIDs) > 0) {
$mandatoryDisplay = false;
$selected = array();
- $i = 0;
if (is_object($ah)) {
$selected = $ah->getExtraFieldData();
$efInFormula = $ath->getExtraFieldsInFormula();
@@ -688,13 +687,13 @@ EOS;
$content_id = (int)$request->get('content_id');
if ($title) {
$sql = "UPDATE artifact_display_widget SET title = $1 WHERE owner_id =$2 AND id = $3";
- $res = db_query_params($sql,array($title, $this->owner_id, $content_id));
+ db_query_params($sql,array($title, $this->owner_id, $content_id));
$done = true;
}
$trackerrows = getArrayFromRequest('trackercontent_layout');
$trackerextrafields = getArrayFromRequest('trackercontent_ef');
$trackercelltitles = getArrayFromRequest('trackercontent_title');
- $res = db_query_params('DELETE FROM artifact_display_widget_field WHERE id = $1', array($content_id));
+ db_query_params('DELETE FROM artifact_display_widget_field WHERE id = $1', array($content_id));
foreach ($trackerrows as $rowkey => $trackerrow) {
$columns = explode(',', $trackerrow);
$extrafields = explode(',', $trackerextrafields[$rowkey]);
-----------------------------------------------------------------------
Summary of changes:
src/common/widget/WidgetLayoutManager.class.php | 7 +++----
src/common/widget/Widget_MyAdmin.class.php | 1 -
src/common/widget/Widget_ProjectLatestDocuments.class.php | 1 -
src/common/widget/Widget_Rss.class.php | 1 -
src/common/widget/Widget_TrackerContent.class.php | 11 +++++------
5 files changed, 8 insertions(+), 13 deletions(-)
hooks/post-receive
--
FusionForge
More information about the Fusionforge-commits
mailing list