[Fusionforge-general] [PATCH] Add feature : sys_use_tag

Roland Mas lolando at debian.org
Fri Apr 3 11:22:40 CEST 2009


Julien Heyman, 2009-04-03 10:50:14 +0200 :
[...]

  First remark: I'd rather call the option sys_use_project_tags (with or
without the project_ part, but definitely plural).  Also, I recommend
using util_make_url() when generating links or redirection headers (in
www/softwaremap/index.php).

  Apart from that, I'm fine with the patch.  It could have been a little
easier to review if you explained what it did (I was about to disagree
about unconditionnally displaying the Projects tab, and redirecting to
the tag cloud, before I later understood that it all led to a menu
anyway), but that's nitpicking.  Feel free to commit (with the two
changes mentioned above).

Roland.
-- 
Roland Mas

Reincarnation likes a joke as much as the next philosophical hypothesis.
  -- in The Truth (Terry Pratchett)




More information about the Fusionforge-general mailing list