[Fusionforge-general] RE : User an Project with the same unix_name
Julien HEYMAN
julien.heyman at atosorigin.com
Wed Jun 17 21:33:24 CEST 2009
AlJeux a écrit :
> Yes, very nice patch.
>
> You can maybe try to replace the LIKE with = in sysUseUnixName().
>
> Alain.
>
> christian.bayle at orange-ftgroup.com a écrit :
>> Hi
>>
>> looks good for me and should satify Alain, as it doesn't change
>> default behaviour,
>> for install not using shell account.
>>
>> Cheers
>>
>> Christian
>>
>> -------- Message d'origine--------
>> De: fusionforge-general-bounces at lists.fusionforge.org de la part de
>> Julien HEYMAN
>> Date: mer. 17/06/2009 15:11
>> À: Christian BAYLE
>> Cc: fusionforge-general at lists.fusionforge.org
>> Objet : Re: [Fusionforge-general] User an Project with the same
>> unix_name
>>
>> Christian BAYLE a écrit :
>> > Hello
>> >
>> > I just suggest that the system check is done in system class
>> > It may be needed to add specific functions like validateUser
>> validateGroup
>> > Like this, someone that would want a different behaviour, could just
>> > replace the standart class (e.g. pgsql.class with nss), because for
>> > example his policy is to use external uid/gid and account are
>> created on
>> > a separate server
>> > I would suggest the is no sys_use_shell var, and that all sys related
>> > call are in System.class or derivated
>> > This system stuff should probably be a plugin.
>> >
>> > Another simple solution may be to make unix group name called
>> something
>> > like prj_<group_name>, like this you won't get name collision, or
>> did I
>> > missed somthing ?
>> >
>> > Christian
>> >
>> >
>> >
>> > Julien HEYMAN a écrit :
>> > >> Christian BAYLE a écrit :
>> >> >>> Hi,
>> >>>
>> >>> As I said this restriction is linked to system restriction
>> >>> system restriction should be in system code
>> >>> You may have install where the restriction don't apply and other
>> with
>> >>> some specific restriction
>> >>> Why not just add the check in sysCheckUser and sysCheckGroup
>> functions,
>> >>> or add sysValidateUser sysValidateGroup if necessary.
>> >>> you can even choose to implement differently depending on the
>> class you
>> >>> choose
>> >>> LDAP, UNIX, pgsql, whatever
>> >>>
>> >>>
>> >>> >
>> > >> Hi,
>> >>
>> >> sysCheckUser and sysCheckGroup is used after user or group is
>> created.
>> >> So we test it before, before than the user or the group are added in
>> >> users/groups tables.
>> >>
>> >> and if I test with getent group, it works only after cron
>> homedirs.php
>> >> was run.
>> >>
>> >> So, I can conditionated my patch by sys_use_shell, but when we
>> active
>> >> the shell, we can have many problems.
>> >>
>> >> >
>> >
>> > _______________________________________________
>> > Fusionforge-general mailing list
>> > Fusionforge-general at lists.fusionforge.org
>> >
>> http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general
>>
>> >
>> >
>> > Ok, I attach my new patch.
>>
>> What do you think ?
>>
>>
>> --
>> Julien HEYMAN
>> Open Source Center - Atos Origin
>> www.portaildulibre.fr
>>
>> Les Miroirs - 18 avenue d'Alsace
>> 92926 Paris La Défense CEDEX
>> Tél : +33 01 55 91 20 00
>> www.atosorigin.com
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Fusionforge-general mailing list
>> Fusionforge-general at lists.fusionforge.org
>> http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general
>>
>
>
> _______________________________________________
> Fusionforge-general mailing list
> Fusionforge-general at lists.fusionforge.org
> http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general
>
>
Ok, thanks. I'll replace and I'll commit it :)
--
Julien HEYMAN
Open Source Center - Atos Origin
www.portaildulibre.fr
Les Miroirs - 18 avenue d'Alsace
92926 Paris La Défense CEDEX
Tél : +33 01 55 91 20 00
www.atosorigin.com
More information about the Fusionforge-general
mailing list