[Fusionforge-general] My mistakes, but please be polite with your fellow contributors - Was: Re: [Fusionforge-commits] r16019 - in branches/Branch_5_2/src: debian plugins/scmgit/common

Franck Villaume franck.villaume at trivialdev.com
Sat Jul 21 08:53:51 CEST 2012


Le 21/07/2012 07:24, Olivier Berger a écrit :
> Hi.
> 
> ----- Mail original -----
>> De: "Franck Villaume" <franck.villaume at trivialdev.com>
> 
> SNIP
> 
>>
>> The file errors were missing for debian... !!!
>> Fix your distro !!!
>>
> 
> Fix your temper ! ;-)
> 
> Hello to you too, Franck... Uh... don't need to be rude ! I committed, you committed... it's just a commit, OK ?

Sorry to be rude here.
That was not my intention.


> 
>>> branches/Branch_5_2/src/plugins/scmgit/common/GitPlugin.class.php
>>
>>
>> This commit just broke my install... as I'm not using debian...
>>
> 
> And I guess you're using svn directly, for an install, then ? ... why not try and use something tested (your preferred distro) ? ... mistakes can happen, as you see. I too can criticize other's work, eh ! ;-)

Criticism is always welcome. I do use direct svn.

> 
>> Please before modify the code you should probably adapt debian code,
>> create a patch for debian and not modify the general code...
>>
> 
> Sorry about breaking more than I expected, but it's difficult to know in advance the impact, provided the variety of installations people do from the code in SVN.
> 
> Maybe if we had VMs installed to test automatically, that'd help, but we haven't, and there's no real commit approval enforced in the project (should we use gerrit and proof-read avery commit ?), so, I guess you have to expect people assuming false assumptions when they push their changes.
> 
>> This is not the first time I explain that fusionforge repo is not
>> debian
>> repo only... put your debian stuff in your own repo !!!
> 
> And if there was no Debian people working, you could as well complain of the lack of activity either ?

???


> 
>>
>> Stop breaking other distro install !!!
>>
>> I will revert the change if no answer.
>>
> 
> Yes, stop yelling at me and revert this one commit. Unless we have tighter rules for verifying incoming commits, I guess we have to assume people will make mistakes and be prepared to revert, or double check before checking out something to be installed.
> 
> Remember : as we say in french "il n'y a que celui qui ne fait rien, qui ne fait pas de conneries" ;-)
> 
> Best regards,
> --
> Olivier BERGER 
> http://www-public.it-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8
> Ingenieur Recherche - Dept INF
> Institut Mines-Telecom, Telecom SudParis, Evry (France)
> 


-- 
TrivialDev Founder
http://trivialdev.com





More information about the Fusionforge-general mailing list