[Fusionforge-general] Mailing-lists creation : debian specific vs. fusionforge standard cronjob

Franck Villaume franck.villaume at trivialdev.com
Fri Jul 27 21:17:03 CEST 2012


Le 24/07/2012 15:33, Roland Mas a écrit :
> Franck Villaume, 2012-07-22 19:26:02 +0200 :
> 
>> Hi all,
>>
>> Currently, 2 issues are open about mailing-lists.
>> https://fusionforge.org/tracker/index.php?func=detail&aid=221&group_id=6&atid=105
>> https://fusionforge.org/tracker/index.php?func=detail&aid=391&group_id=6&atid=105
>>
>> Theses issues affected one file : src/cronjobs/mail/mailing_lists_create.php
>>
>> This script is a cronjob used to create mailing-lists for everyone
>> except for debian which seems to use his own cronjob written in perl
>> available in src/deb-specific/create-mailing-lists.pl
> 
>   Yeah.  Both scripts seem to have coexisted for at least 10 years.
> 
>> I spent few hours to fix and enhanced the mailing-list interface to make
>> it work correctly with the standard cronjob BUT if I commit my work, I
>> might break the debian specific script...
> 
>   Probably will.
> 
>> EXPLANATION :
>> in debian, once create-mailing-lists.pl is executed, mailing-list status
>> is 3, everywhere else mailing-list status is 2.
>>
>> QUESTION :
>> why debian is not following the documentation ? fusionforge
>> documentation INSTALL.TXT says : mailing-list cronjob is in
>> cronjobs/mail/
> 
>   This is probably of historical interest only, but that part of the
> documentation was probably written in GForge, and the Perl script in
> Debian-SF, before these branches were merged (in December of 2002).
> 
>> SOLUTION :
>> Use a common script. Let's say : follow the documentation and use the
>> mailing_lists_create.php
>>
>> - commit my change.
>> - drop the create-mailing-lists.pl
>> - update the mailing-list status to 3.
> 
>   That should work, although there is another thing: the Perl script
> configures the list's host_name property to match the FF lists_host
> configuration variable, then invokes the "fix_url" script provided by
> Mailman to ensure that the URLs are correct.  This is probably doable
> with the PHP script too.

I will include these features in the PHP script.

> 
>> My waiting changes are branch 5.1 based. I'm ready to merge it to
>> branch 5.2 and trunk.
> 
> [...]
> 
>> COMMENTS :
>> Any feedback ? Any advice ?
> 
>   I'd say: go for it.  This will probably temporarily break the Debian
> packaging, but I'll fix that.

Ok. Thanks for the feedback.
I will commit as soon as I can.

Franck



-- 
TrivialDev Founder
http://trivialdev.com



More information about the Fusionforge-general mailing list