[Fusionforge-general] [Fusionforge-commits] r17432 - trunk/src/common/docman/views

Roland Mas lolando at debian.org
Wed Jun 26 09:38:15 CEST 2013


Marc-Etienne VARGENAU, 2013-06-25 09:44:19 +0200 :

> Author: vargenau
> Date: 2013-06-25 09:44:19 +0200 (Tue, 25 Jun 2013)
> New Revision: 17432
>
> Modified:
>    trunk/src/common/docman/views/listtrashfile.php
> Log:
> Less strings
>

[...]

> -	echo '<h3 class="docman_h3" >'._('Documents folder:').' <i>'.$DocGroupName.'</i> ';
> +	echo '<h3 class="docman_h3" >'._('Document Folder')._(': ').' <i>'.$DocGroupName.'</i> ';

  I think this is the sort of thing we discussed and rejected.  Remember
that the rules of where to put the colon differ across languages, and so
the colon must be in the same gettext string as the words themselves.

  Also, could someone unbreak the testsuite?  It seems it got broken
last Friday afternoon:

,----
| 1) CreateProject::testEmptyProject
| PHPUnit_Framework_Exception: Response from Selenium RC server for testComplete().
| ERROR: Element //input[@name='type' and @value='folder'] not found.
`----

  Thanks,

Roland.
-- 
Roland Mas

Meaning lies as much / In the mind of the reader / As in the haiku
  -- in Gödel, Escher, Bach: an Eternal Golden Braid (Douglas Hofstadter)



More information about the Fusionforge-general mailing list