[Fusionforge-general] Can we PLEASE STOP RENAMING API FUNCTIONS!

Roland Mas lolando at debian.org
Wed Mar 27 15:58:10 CET 2013


Thorsten Glaser, 2013-03-25 17:02:21 +0100 :

> -function session_get_session_cookie_hash($session_cookie) {
> +function session_get_hash_from_token($session_token) {
>
> WHY DO YOU RENAME FUNCTIONS THAT ARE PART OF THE API
> BETWEEN VERSIONS?

  I think the rationale was that the token may come from other sources
than just a cookie, even if the current way of getting it is the cookie.

> Stay compatible. Do not rename. If you must, keep wrappers.

  My apologies for the inconvenience, but…

  …on the other hand, I don't think there's an explicit promise not to
break out-of-tree things.  When I change an API, I take it upon me to
port all its users— at least those that are in FusionForge proper, even
the calls that are in parts of the code that I never use myself.  That's
the main rationale behind getting code upstreamed.  In all honesty, I
don't think it's reasonable to expect a guarantee that external code
will always keep working; implementations of the API will change over
time, and the interfaces *will* change over time too.  An extra
parameter here, an existing parameter made compulsory rather than
optional there, a new function elsewhere; most of the time it'll be
backwards-compatible, sometimes it won't.

  Again: I'm sorry for the inconvenience, but if "it"'s not in the FF
tree (and/or if "it" has no testsuite), "it" may get broken from time to
time.

Roland.
-- 
Roland Mas

Depuis 1977.



More information about the Fusionforge-general mailing list